Skip to content

add legend style option : size, front, color - #375

Merged
ghtmtt merged 4 commits into
ghtmtt:masterfrom
soaubier:legend_style
Oct 10, 2025
Merged

add legend style option : size, front, color#375
ghtmtt merged 4 commits into
ghtmtt:masterfrom
soaubier:legend_style

Conversation

@soaubier

@soaubier soaubier commented May 6, 2025

Copy link
Copy Markdown
Contributor

Add style option for all plot type. With the implementation of :

  • PROPERTY_FONT_LEGEND_SIZE
  • PROPERTY_FONT_LEGEND_FAMILY
  • PROPERTY_FONT_LEGEND_COLOR

Funded by INRAE - Reversaal

Capture d’écran du 2025-05-06 14-58-03

Capture d’écran du 2025-05-06 14-51-03

@Djedouas

Djedouas commented May 6, 2025

Copy link
Copy Markdown
Contributor

cc @nforquet

@ghtmtt ghtmtt left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks for this contribution! From the screenshot it seemed that you created already existing properties and not that you added the legend customization!

Not sure what is happening but when opening the UI font, size and color widget are different from all the others. Can you please normalize it?

image

Comment thread DataPlotly/core/plot_settings.py Outdated
Comment on lines +54 to +56
PROPERTY_FONT_LEGEND_SIZE = 27
PROPERTY_FONT_LEGEND_FAMILY = 28
PROPERTY_FONT_LEGEND_COLOR = 29

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you continue the numeration? 30, 31, 32

@soaubier

Copy link
Copy Markdown
Contributor Author

Hi @ghtmtt ,

Thank you for your review !
I’ve considered your feedback. Please let me know if I missed anything.

@ghtmtt

ghtmtt commented Sep 25, 2025

Copy link
Copy Markdown
Owner

@soaubier there are some conflicts, can you fix them? So I'll merge this PR! Thanks!

@soaubier

soaubier commented Oct 2, 2025

Copy link
Copy Markdown
Contributor Author

Hi @ghtmtt ,

thanks for the quick reply!
I pushed some changes to fix the conflicts, which revealed an issue. I decided to remove the handling of axis color/size for the pie chart and the ternary chart because:

  • the pie chart doesn’t have real x or y axes,

  • the ternary chart has x, y, and z, but since I didn’t handle z, I also removed x and y for consistency.

They still keep support for title and legend.

@ghtmtt

ghtmtt commented Oct 10, 2025

Copy link
Copy Markdown
Owner

thanks @soaubier! LGTM, I'm going to merge the pull request and release a new version ASAP

@ghtmtt
ghtmtt merged commit 62b5ec3 into ghtmtt:master Oct 10, 2025
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants