feat(chunks): Accept android profiles in sample v2 format by markushi · Pull Request #93 · getsentry/vroomrs

markushi · 2026-07-02T12:30:43Z

Dispatch profile chunk deserialization on the profile version instead of the platform.

Previously any chunk with platform: "android" was assumed to be in the legacy android trace format, so android profiles in the sample v2 format (version: "2", emitted by newer Android SDKs) could not be processed properly. Relay will soon start emitting version: "2.android-trace" for chunks in the legacy trace format, which makes the version the reliable discriminator.

Changes:

Add ProfileChunk::from_json_vec_**and_version**: "" | "2.android-trace" maps to the legacy android trace format, any other version to sample v2.
Deprecate ProfileChunk::from_json_vec_and_platform in favor of the new method
The version is now persisted within the android chunk json blob

Transaction-based profiles (Profile) are unaffected; the new version only applies to profile chunks.

This unblocks sample v2 android support in the consuming service: getsentry/sentry#118849.
The vroom service changes are already merged / shipped: getsentry/vroom#672

Fixes JAVA-603

🤖 Generated with Claude Code

linear-code · 2026-07-02T12:30:46Z

JAVA-603

markushi · 2026-07-02T12:36:40Z

@sentry review

Relay will start emitting version "2.android-trace" for android profiles in the legacy android trace format, while android profiles in the sample v2 format carry version "2". Previously any profile with platform "android" was assumed to be in the legacy trace format, so sample v2 android chunks could not be processed. Dispatch profile chunk deserialization on the version instead of the platform: add ProfileChunk::from_json_vec_and_version and deprecate from_json_vec_and_platform, since the platform alone cannot distinguish the two formats. profile_chunk_from_json_str accepts a new optional version argument that takes precedence over platform. As a fallback to the legacy behavior in vroom, a missing or empty version is treated as the android trace format, and AndroidChunk now retains the version field so it survives compression round trips. Fixes JAVA-603 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

vroom maps any non-empty version to the sample format when reading chunks from storage, so persisting "2.android-trace" would break its read path. Drop the version field from AndroidChunk: unknown fields are ignored during deserialization, so ingest still accepts payloads carrying the new version, while stored chunks remain version-less and readable by both vroom and vroomrs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

This reverts commit 25cb74d.

0xadam-brown

Thanks a bunch for this!

A few comments; otherwise looking great 🙌

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit b3201f1. Configure here.}

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

The Android SDK can now emit **sample v2** profiles in addition to the legacy android trace format. This wires the profiling pipeline to be able to process both. The whole pipeline previously always assumed that `platform="android"` provided a profile in the Android trace format - regardless if `version="2"` was set or not. `platform: "java"` profiles (aka profiles from backend services) are intentionally not deobfuscated for now, but support could be easily added. Also removes `get_data_category`, dead code since #81481. > [!NOTE] > `vroom` and `vroomrs` need to be updated as well to support the sample v2 Android format. > See getsentry/vroom#672 (was automatically deployed earlier this week) > and getsentry/vroomrs#93 (landed in `0.1.22`, which is bumped in this PR as well) ### Testing - Unit tests for the classifiers, frame conversion and the sample v2 merge/stack-remap (inline expansion + native passthrough). - Symbolicator integration tests for sample v2 (basic + inline) plus a full `process_profile_task` run. --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

Commit updates the platform used with ANR profiles from Java to Android so that we can properly bill ANR profiling under UI Profile Hours rather than Continuous Profile Hours. Depends on the updates made in [Relay #6183](getsentry/relay#6183), [getsentry #118849](getsentry/sentry#118849), [vroomrs #93](getsentry/vroomrs#93), and [vroom #672](getsentry/vroom#672).

Commit updates the platform used with ANR profiles from Java to Android so that we can properly bill ANR profiling under UI Profile Hours rather than Continuous Profile Hours. Depends on the updates made in [Relay #6183](getsentry/relay#6183), [getsentry #118849](getsentry/sentry#118849), [vroomrs #93](getsentry/vroomrs#93), and [vroom #672](getsentry/vroom#672). # Conflicts: # CHANGELOG.md

#5836) Commit updates the platform used with ANR profiles from Java to Android so that we can properly bill ANR profiling under UI Profile Hours rather than Continuous Profile Hours. Depends on the updates made in [Relay #6183](getsentry/relay#6183), [getsentry #118849](getsentry/sentry#118849), [vroomrs #93](getsentry/vroomrs#93), and [vroom #672](getsentry/vroom#672). Co-authored-by: Markus Hintersteiner <markus.hintersteiner@sentry.io>

markushi commented Jul 2, 2026

View reviewed changes

Comment thread src/android/chunk.rs

markushi marked this pull request as ready for review July 2, 2026 13:01

markushi requested a review from a team as a code owner July 2, 2026 13:01

markushi requested a review from 0xadam-brown July 2, 2026 13:01

markushi force-pushed the markushintersteiner/java-603-update-vroomrs-to-accept-android-profiles-in-v2-format branch from 6c14764 to d670a07 Compare July 2, 2026 13:37

markushi mentioned this pull request Jul 3, 2026

feat(profiling): Support sample v2 profiles for Android getsentry/sentry#118849

Merged

Revert "ref(chunks): Do not persist the version on android chunks"

18ebc83

This reverts commit 25cb74d.

0xadam-brown reviewed Jul 3, 2026

View reviewed changes

Comment thread src/lib.rs Outdated

Comment thread src/lib.rs Outdated

Comment thread src/lib.rs

Comment thread src/profile_chunk.rs Outdated

ref(chunks): Split version-based chunk parsing into its own function

b3201f1

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

cursor Bot reviewed Jul 3, 2026

View reviewed changes

Comment thread src/android/chunk.rs

sentry Bot reviewed Jul 3, 2026

View reviewed changes

Comment thread src/android/chunk.rs

0xadam-brown mentioned this pull request Jul 6, 2026

fix(profiling): Fix accidentally correct Android profile chunk parsing getsentry/relay#6183

Merged

manessaraj approved these changes Jul 8, 2026

View reviewed changes

chore(docs): Fix doc strings

22885f1

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Dav1dde approved these changes Jul 9, 2026

View reviewed changes

markushi merged commit f512c83 into main Jul 9, 2026
18 checks passed

markushi deleted the markushintersteiner/java-603-update-vroomrs-to-accept-android-profiles-in-v2-format branch July 9, 2026 07:13

0xadam-brown mentioned this pull request Jul 24, 2026

fix(anr-profiling): Properly bill ANR profiling under UI Profile Hours getsentry/sentry-java#5836

Merged

12 tasks

Navigation Menu

Uh oh!

Uh oh!

feat(chunks): Accept android profiles in sample v2 format - #93

feat(chunks): Accept android profiles in sample v2 format#93
markushi merged 5 commits into
mainfrom
markushintersteiner/java-603-update-vroomrs-to-accept-android-profiles-in-v2-format

markushi commented Jul 2, 2026 •

edited

Loading

Uh oh!

linear-code Bot commented Jul 2, 2026

Uh oh!

markushi commented Jul 2, 2026

Uh oh!

Uh oh!

0xadam-brown left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

markushi commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear-code Bot commented Jul 2, 2026

Uh oh!

markushi commented Jul 2, 2026

Uh oh!

Uh oh!

0xadam-brown left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

markushi commented Jul 2, 2026 •

edited

Loading