ref(crash): Replace relay-crash with minidumper#6158
Open
Dav1dde wants to merge 1 commit into
Open
Conversation
Dav1dde
force-pushed
the
dav1d/minidumper
branch
5 times, most recently
from
af451fa to
002d2cf
Compare
Dav1dde
force-pushed
the
dav1d/minidumper
branch
4 times, most recently
from
995983c to
b24de58
Compare
Dav1dde
force-pushed
the
dav1d/minidumper
branch
2 times, most recently
from
e0c2d06 to
4280ecb
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
loewenheim
requested changes
Jul 3, 2026
| ); | ||
|
|
||
| if child.is_crash_reporter_process() { | ||
| // Set the event.origin so that it's obvious when Rust events come from |
Contributor
There was a problem hiding this comment.
This says event.origin but the code says event.process.
This comment was marked as low quality.
This comment was marked as low quality.
Sorry, something went wrong.
loewenheim
approved these changes
Jul 3, 2026
Contributor
|
PR description still says
but that no longer appears to be true. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently uses a pinned commit of a fork of
minidumper-child, otherwise confirmed working (See timfish/minidumper-child#6).This is an out of process crash reporter (as opposed to the sentry-native variant we've been using before). It works by compiling the entire machinery into Relay and spawning a server process (the crash reporter) from the same binary.
This gets rid of the entire
sentry-nativeand breakpad dependency, while hopefully also being more reliable and supported on more platforms.Closes: #5453
RIP sentry-native.