Skip to content

feat(memory): Authorize web memory reads by linked identities - #1637

Open
sentry-junior[bot] wants to merge 14 commits into
mainfrom
feat/web-memory-linked-identities
Open

feat(memory): Authorize web memory reads by linked identities#1637
sentry-junior[bot] wants to merge 14 commits into
mainfrom
feat/web-memory-linked-identities

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Web turns can now read memory through the current person's linked identities. A verified web email resolves the canonical Junior identity and linked Slack identities, so public workspace memory is available on the web surface.

Read tools and automatic recall use linked identity scopes. Memory writes stay bound to the current Actor and Source. Identity lookup fails closed.

The component test covers the full web path and proves that memory from an unlinked Slack workspace stays hidden.

Closes #1636.

Requested by David Cramer.

--

View Junior Session [Sentry]

sentry-junior Bot and others added 2 commits August 20, 2026 19:26
Web turns now resolve the canonical user and include linked Slack
workspace scopes for memory recall and tools. Public workspace memory
follows person identity rather than surface-only Actor/Source scopes.

Co-Authored-By: David Cramer <david@sentry.io>
Co-Authored-By: David Cramer <david@sentry.io>
@vercel

vercel Bot commented Aug 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
junior-docs Ready Ready Preview Aug 21, 2026 5:21am

Request Review

@dcramer
dcramer marked this pull request as ready for review August 20, 2026 19:47
@github-actions github-actions Bot added the risk: high PR risk score: high label Aug 20, 2026
Comment thread packages/junior-memory/src/plugin.ts Outdated
Comment thread packages/junior-memory/src/plugin.ts Outdated
Comment thread packages/junior-memory/src/linked-identities.ts Outdated
@github-actions github-actions Bot added risk: medium PR risk score: medium and removed risk: high PR risk score: high labels Aug 20, 2026
Comment thread packages/junior-memory/src/linked-identities.ts Outdated
Comment thread packages/junior-memory/src/types.ts Outdated
Comment thread packages/junior/tests/component/memory-plugin-storage.test.ts
Co-Authored-By: David Cramer <david@sentry.io>
@github-actions github-actions Bot added risk: high PR risk score: high and removed risk: medium PR risk score: medium labels Aug 20, 2026
Co-Authored-By: David Cramer <david@sentry.io>
@github-actions

Copy link
Copy Markdown

Dashboard visual evidence

No matching dashboard scenarios for this diff.

Comment thread packages/junior-memory/src/plugin.ts Outdated
Comment thread packages/junior-memory/src/linked-identities.ts Outdated
Comment thread packages/junior/src/chat/plugins/viewer.ts

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 987e747. Configure here.

Comment thread packages/junior/src/chat/plugins/viewer.ts Outdated
Comment thread packages/junior-memory/src/scope.ts Outdated
Comment thread packages/junior-memory/src/tools.ts Outdated
Comment thread packages/junior-memory/src/tools.ts Outdated
Comment thread packages/junior-memory/src/plugin.ts Outdated

@dcramer dcramer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean this up - you're approaching this wrong with excessive DI and the wrong shape

Comment thread packages/junior/src/chat/plugins/agent-hooks.ts Outdated
Comment thread packages/junior-memory/tests/storage.test.ts Outdated
Comment thread packages/junior-memory/src/types.ts Outdated
Comment thread packages/junior-memory/src/tools.ts Outdated
Comment thread packages/junior-plugin-api/src/tools.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: high PR risk score: high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Authorize web memory by linked identities

1 participant