fix(github): own review threads by bot user id - #1623
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Review-thread resolve compared GraphQL author.login to the noreply bot login. GitHub GraphQL Bot.login omits [bot], so every Junior- authored PR failed the ownership gate. Use the bot user id already encoded in GITHUB_APP_BOT_EMAIL and compare it to author.databaseId from the GraphQL payload. Evidence: #jr-cramer on #1614; JUNIOR-89 Co-Authored-By: David Cramer <david@sentry.io>
sentry-junior
Bot
force-pushed
the
fix/github-graphql-bot-login-thread-resolve
branch
from
August 19, 2026 22:20
a4b41dd to
67ac2e4
Compare
dcramer
marked this pull request as ready for review
August 19, 2026 22:31
dcramer
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What failed
Junior refused to resolve a review thread on its own PR.
Root cause
GitHub returns different bot login shapes. REST uses
sentry-junior[bot]. GraphQLBot.loginusessentry-junior.The configured noreply email already encodes the stable bot user id. The review-thread GraphQL payload also exposes that id as
Bot.databaseId.Fix
Parse the documented GitHub bot noreply format once. Compare its user id with
author.databaseId. Keep the repository match. Do not use login or another fallback identity path.Verification
author.databaseId: 264270552.pnpm --filter @sentry/junior-github exec vitest run tests/resolve-pull-request-review-thread.test.ts tests/webhook-outcomes.test.ts tests/commit-composition.test.ts— 44 passed.Evidence
slack:C0B595QDZLL:1787171595.435169Requested by David Cramer.
--
View Junior Session [Sentry]