fix: static analysis under-reports Swift value types - #28
Open
kcsiegal wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed while using Reaper in a production app that the SDK was reporting a surprisingly large set of Swift structs and enums at runtime that the static analysis was not detecting in the app bundle.
The underlying cause is an incorrectly bounded loop in
validSwiftTypesForReaperwhen iterating over the__swift5_typessection. The section is an array of 4-byte relative pointers and the loop correctly strides by 4, but it bounds itself atswiftTypesData.length / 8, so the second half of the section is never visited. UpdatingnumTypestoswiftTypesData.length / 4surfaces the missing value types.