refactor: upgrade gobox to v1.116.0 and adopt pkg/set for dependency dedup - #1178
Merged
Conversation
malept
force-pushed
the
claude/hand-rolled-sets-go-q85yhq
branch
from
August 6, 2026 02:46
b775708 to
67022ca
Compare
…dedup
The dependency set in e2e/e2e.go was a hand-rolled map[string]struct{}
used purely for membership testing and deduplication during dependency
graph traversal. Replace it with gobox/pkg/set.Set, which now ships
generic set operations (Insert, Contains, Slice, All, etc.).
malept
force-pushed
the
claude/hand-rolled-sets-go-q85yhq
branch
from
August 6, 2026 02:48
67022ca to
04e5544
Compare
|
Link to code coverage report (posted by coverbot 🤖) |
ekalinichev
approved these changes
Aug 6, 2026
Contributor
|
🎉 This PR is included in version 2.39.2-rc.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 2.39.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
The e2e dependency resolver in
e2e/e2e.gobuilt its dedup/cycle-guard set by hand with amap[string]struct{}. Now that gobox ships a genericpkg/setpackage, bump gobox to v1.116.0 and switch the resolver over toset.Set[string]instead of maintaining the map manually.