Skip to content

ci: bump pinned GitHub Actions to their Node 24 majors #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EtienneLescot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: bump pinned GitHub Actions to their Node 24 majors #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/setup/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: Install Node 22, restore npm cache, run npm ci
runs:
using: composite
steps:
- uses: actions/setup-node@v4
- uses: actions/setup-node@v7

@EtienneLescot EtienneLescot Jul 17, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✓ Correct bump. setup-node@v7 declares using: node24 at this tag. Note that node-version: 22 on line 8 is intentional — the app's package.json#engines pins Node 22.22.1, and the composite action installs Node 22 for npm ci. The Node 24 only affects the runner side (the action's dist/setup/index.js), not the version installed for the app. No drift between runner-side (24) and app-side (22); the two are independent.

Recommend a one-line comment in this file (or in docs/github-actions-workflows.md) explaining the distinction so future maintainers don't "fix" the node-version: 22 to node-version: 24.

with:
node-version: 22
cache: npm
Expand Down
30 changes: 15 additions & 15 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,13 @@ jobs:
runs-on: windows-latest

@EtienneLescot EtienneLescot Jul 17, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✓ Bump to actions/checkout@v7 is correct (uses node24 at this tag). The fetch-depth / repository / token inputs are all still supported. Verified that none of this repo's checkout calls use removed v4 inputs.

steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v7

- name: Setup Node.js
uses: ./.github/actions/setup

- name: Cache caption assets
uses: actions/cache@v4
uses: actions/cache@v6
with:
path: caption-assets
key: caption-assets-${{ runner.os }}-${{ hashFiles('scripts/fetch-caption-model.mjs') }}
Expand All @@ -48,7 +48,7 @@ jobs:
run: npm run build:win -- --publish never

- name: Upload Windows installer
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: openscreen-windows
path: release/**/Openscreen.Setup.*.exe
Expand All @@ -64,13 +64,13 @@ jobs:
arch: ${{ fromJSON((github.event_name == 'workflow_dispatch' && github.event.inputs.arch != 'both') && format('["{0}"]', github.event.inputs.arch) || '["arm64", "x64"]') }}
steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v7

- name: Setup Node.js
uses: ./.github/actions/setup

- name: Setup Python
uses: actions/setup-python@v5
uses: actions/setup-python@v6
with:
python-version: "3.11"

Expand All @@ -80,7 +80,7 @@ jobs:
npm_config_build_from_source: "false"

- name: Cache caption assets
uses: actions/cache@v4
uses: actions/cache@v6
with:
path: caption-assets
key: caption-assets-${{ runner.os }}-${{ hashFiles('scripts/fetch-caption-model.mjs') }}
Expand Down Expand Up @@ -218,7 +218,7 @@ jobs:
spctl -a -vv -t install "${{ steps.dmg.outputs.dmg_path }}"

- name: Upload macOS DMG
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: openscreen-mac-${{ matrix.arch }}
path: ${{ steps.dmg.outputs.dmg_path }}
Expand All @@ -234,7 +234,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v7

- name: Setup Node.js
uses: ./.github/actions/setup
Expand All @@ -243,7 +243,7 @@ jobs:
run: sudo apt-get update && sudo apt-get install -y libarchive-tools

- name: Cache caption assets
uses: actions/cache@v4
uses: actions/cache@v6
with:
path: caption-assets
key: caption-assets-${{ runner.os }}-${{ hashFiles('scripts/fetch-caption-model.mjs') }}
Expand All @@ -252,7 +252,7 @@ jobs:
run: npm run build:linux -- --publish never

- name: Upload Linux packages
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: openscreen-linux
path: |
Expand All @@ -273,7 +273,7 @@ jobs:
if: ${{ (github.event_name == 'push' && github.ref_type == 'tag') || (github.event_name == 'workflow_dispatch' && github.event.inputs.release_tag != '') }}
steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v7

- name: Resolve release tag
id: release
Expand Down Expand Up @@ -331,27 +331,27 @@ jobs:
echo "notes_start_tag=$NOTES_START_TAG" >> "$GITHUB_OUTPUT"

- name: Download Windows installer
uses: actions/download-artifact@v4
uses: actions/download-artifact@v8
with:
name: openscreen-windows
path: artifacts/windows

- name: Download macOS arm64 DMG
continue-on-error: true
uses: actions/download-artifact@v4
uses: actions/download-artifact@v8
with:
name: openscreen-mac-arm64
path: artifacts/mac-arm64

- name: Download macOS x64 DMG
continue-on-error: true
uses: actions/download-artifact@v4
uses: actions/download-artifact@v8
with:
name: openscreen-mac-x64
path: artifacts/mac-x64

- name: Download Linux packages
uses: actions/download-artifact@v4
uses: actions/download-artifact@v8
with:
name: openscreen-linux
path: artifacts/linux
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/bump-nix-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
echo "branch=$BRANCH" >> "$GITHUB_OUTPUT"

- name: Checkout main
uses: actions/checkout@v4
uses: actions/checkout@v7
with:
ref: main
fetch-depth: 0
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,23 +11,23 @@ jobs:
name: Lint

@EtienneLescot EtienneLescot Jul 17, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✓ All four bumps here are actions/checkout@v4 → @v7. These run on ubuntu-latest only. Worth noting: the Lint / Type Check / Test / Build / Validate PR title (semantic) jobs all reference this checkout — bumping to v7 transitively bumps the runner to Node 24 for the entire ci.yml pipeline. Good preventive maintenance before GitHub forces the migration.

runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v7
- uses: ./.github/actions/setup
- run: npm run lint

typecheck:
name: Type Check
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v7
- uses: ./.github/actions/setup
- run: npx tsc --noEmit

test:
name: Test
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v7
- uses: ./.github/actions/setup
- run: npm run test
- run: npm run test:browser:install
Expand All @@ -37,7 +37,7 @@ jobs:
name: Build
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v7
- uses: ./.github/actions/setup
- run: npx vite build

Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/diagnostic-artifact.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
name: Windows x64 diagnostic bundle

@EtienneLescot EtienneLescot Jul 17, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✓ actions/upload-artifact@v7 and actions/checkout@v7 are the right targets. The diagnostic bundle jobs run on windows-latest, macos-latest, macos-15-intel — bumping these also brings Node 24 to all three platforms' runners. The if-no-files-found, retention-days, and name inputs are still supported.

runs-on: windows-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v7

- uses: ./.github/actions/setup

Expand Down Expand Up @@ -58,7 +58,7 @@ jobs:
if ($LASTEXITCODE -ne 0) { throw "diagnostic.bat --help exited $LASTEXITCODE" }

- name: Upload Windows diagnostic bundle
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: openscreen-diagnostic-windows-x64
path: openscreen-diagnostic-windows-x64.zip
Expand All @@ -73,7 +73,7 @@ jobs:
matrix:
arch: [arm64, x64]
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v7

- uses: ./.github/actions/setup

Expand All @@ -98,7 +98,7 @@ jobs:
tar -czf "$bundle.tar.gz" "$bundle"

- name: Upload macOS diagnostic bundle
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: openscreen-diagnostic-macos-${{ matrix.arch }}
path: openscreen-diagnostic-macos-${{ matrix.arch }}.tar.gz
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/discord-pr-notify.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v7

- name: Setup Node.js
uses: ./.github/actions/setup
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/discord-roadmap-sync.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v7

- name: Setup Node.js
uses: ./.github/actions/setup
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/discord-weekly-leaderboard.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v7

- name: Setup Node.js
uses: ./.github/actions/setup
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/prerelease.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v7
with:
fetch-depth: 0

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/promote.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v7
with:
fetch-depth: 0

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-homebrew-cask.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ jobs:
echo "x64_sha=$X64_SHA" >> "$GITHUB_OUTPUT"

- name: Checkout tap
uses: actions/checkout@v4
uses: actions/checkout@v7
with:
repository: ${{ env.TAP_OWNER }}/${{ env.TAP_REPO }}
token: ${{ secrets.HOMEBREW_TAP_TOKEN }}
Expand Down
Loading