Skip to content

fix(launch): use native window drag for HUD grip on Linux #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EtienneLescot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(launch): use native window drag for HUD grip on Linux #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions src/components/launch/LaunchWindow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -924,14 +924,22 @@ export function LaunchWindow() {
}
}}
>
{/* Drag handle */}
{/* Drag handle. On Linux (notably Wayland), BrowserWindow.setPosition() used by
the pointer-capture drag below is a platform no-op -- compositors don't let
clients reposition themselves outside an OS-initiated interactive move. Fall
back to native `-webkit-app-region: drag` there, same as the HUD bar's border,
which already goes through the OS's own move gesture and works. */}
<div
data-testid="hud-drag-handle"
className={`flex ${trayLayout === "vertical" ? "h-6 w-8" : "h-8 w-7"} cursor-grab items-center justify-center active:cursor-grabbing ${styles.electronNoDrag}`}
onPointerDown={handleHudDragPointerDown}
onPointerMove={handleHudDragPointerMove}
onPointerUp={handleHudDragPointerEnd}
onPointerCancel={handleHudDragPointerEnd}
className={`flex ${trayLayout === "vertical" ? "h-6 w-8" : "h-8 w-7"} cursor-grab items-center justify-center active:cursor-grabbing ${isLinuxHud ? styles.electronDrag : styles.electronNoDrag}`}
{...(isLinuxHud
? {}
: {
onPointerDown: handleHudDragPointerDown,
onPointerMove: handleHudDragPointerMove,
onPointerUp: handleHudDragPointerEnd,
onPointerCancel: handleHudDragPointerEnd,
})}
>
{getIcon("drag", "text-white/30")}
</div>
Expand Down
Loading