Skip to content

chore: temp workflow to fire the missed v1.7.0 Discord announce#137

Merged
EtienneLescot merged 1 commit into
mainfrom
chore/temp-discord-announce
Jul 19, 2026
Merged

chore: temp workflow to fire the missed v1.7.0 Discord announce#137
EtienneLescot merged 1 commit into
mainfrom
chore/temp-discord-announce

Conversation

@EtienneLescot

@EtienneLescot EtienneLescot commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator

Promote RC failed at the merge step twice, so the Discord-announce step in promote.yml never ran for the v1.7.0 stable release (which is already published: https://github.com/getopenscreen/openscreen/releases/tag/v1.7.0). This is a one-off workflow to re-run just that step. Will be removed via a follow-up PR right after use.

Summary by CodeRabbit

  • New Features
    • Added a manually triggered workflow for announcing stable releases in Discord.
    • Release announcements can be targeted using a specified stable release tag.

Promote RC failed at the merge step twice, so the Discord-announce step
in promote.yml never ran for the v1.7.0 stable release. This one-off
workflow re-runs just that step against the already-published release.
Will be reverted immediately after use.
@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Adds a manually triggered GitHub Actions workflow that accepts a stable release tag and runs the local Discord release announcement script with configured tokens, channel information, and release metadata.

Changes

Discord release announcement

Layer / File(s) Summary
Manual announcement workflow
.github/workflows/temp-discord-announce.yml
Adds a required stable_tag dispatch input, read-only permissions, Node setup, and an announce job that executes the Discord release announcement script with its configured environment variables.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description gives context, but it misses the required template sections like Summary, Type of change, Release impact, and Testing. Fill in the repository template sections: Summary, Related issue, Type of change, Release impact, Desktop impact, Screenshots/video, and Testing.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is specific and matches the main change: a temporary workflow to rerun the missed Discord announcement for v1.7.0.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/temp-discord-announce

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@EtienneLescot
EtienneLescot merged commit e34a75d into main Jul 19, 2026
10 of 11 checks passed
@EtienneLescot
EtienneLescot deleted the chore/temp-discord-announce branch July 19, 2026 23:32

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/temp-discord-announce.yml:
- Around line 6-9: Constrain the stable_tag workflow input to the intended
validated release by hardcoding v1.7.0, or add a preflight check before the
announcement that accepts only the stable promotion tag and verifies it points
to the release-branch tip. Apply this validation in the workflow
input/announcement path and prevent posting when the check fails.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3fb95063-69b3-494f-a260-421684841afa

📥 Commits

Reviewing files that changed from the base of the PR and between 46bf3eb and 7efb085.

📒 Files selected for processing (1)
  • .github/workflows/temp-discord-announce.yml

Comment on lines +6 to +9
stable_tag:
description: "Stable tag to announce (e.g. v1.7.0)"
required: true
type: string

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Constrain the input to a validated stable release.

This free-form input can announce any tag without enforcing the documented RC→stable promotion flow or verifying that the stable tag points to the release-branch tip. For this one-off workflow, hardcode v1.7.0 or add a preflight validation before posting.

As per coding guidelines, release workflows must cut release candidates first, promote them to stable, and ensure stable tags point to the release branch tip.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/temp-discord-announce.yml around lines 6 - 9, Constrain
the stable_tag workflow input to the intended validated release by hardcoding
v1.7.0, or add a preflight check before the announcement that accepts only the
stable promotion tag and verifies it points to the release-branch tip. Apply
this validation in the workflow input/announcement path and prevent posting when
the check fails.

Source: Coding guidelines

EtienneLescot pushed a commit that referenced this pull request Jul 19, 2026
Its job is done — v1.7.0 stable was announced successfully. See PR #137.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants