fix: declare the cue and tab attributes on the links item type - #359
Merged
Conversation
assets/link.html and assets/button.html both accept cue — the per-element
override for main.externalLinks.cue — and content legitimately sets it on an
entry of a links list to suppress the external-link icon on a link that already
carries its own brand icon. The shared links item type does not declare it, so
the v6 validation engine logs warn-invalid-arguments ('unsupported attribute')
on every render of such content.
cue has a global definition in _arguments.yml (bool, optional, no default), so
the member compiles without further changes and an absent value stays absent,
leaving the consuming partial free to apply main.externalLinks.cue.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Companion to the cue declaration. assets/link.html and assets/button.html both
accept tab — the per-element override for main.externalLinks.tab — so an entry
of a links list can keep an external link in the same tab. The shared links item
type did not declare it, so the v6 validation engine logs
warn-invalid-arguments ('unsupported attribute') on such content.
Like cue, tab has a global definition in _arguments.yml (bool, optional, no
default), so the member compiles without further changes and an absent value
stays absent for the consuming partial to resolve.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
🎉 This PR is included in version 6.8.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
assets/link.htmlandassets/button.htmlacceptcueandtab— the per-element overrides formain.externalLinks.cue/.tab— but the sharedlinksitem type declares neither. Content that legitimately sets either on an entry of a links list therefore logswarn-invalid-arguments(unsupported attribute) on every render, through each partial in the chain (hero,section-title,links).Both already have global definitions in
_arguments.yml(bool,optional, no default), so the members compile without further changes and an absent value stays absent, leaving the consuming partial free to apply the site setting.Same shape as #357, which declared
labelandurlon theelementstype.Verification
pnpm test— golden check passes (14 groups).unsupported attribute 'cue'warnings per build drop to zero, with no other change to the build output.Note
This silences the validation warning. Making the attributes actually take effect needs the companion fix in hinode — gethinode/hinode#2092 — which forwards them through
assets/links.htmland stops| defaultfrom swallowing an explicitfalse. The two are independent and safe to merge in either order.🤖 Generated with Claude Code