build(deps): hold entangled major toolchain bumps (jest 30, babel 8, marked 18) - #1635
Merged
Merged
Conversation
…marked 18) Three new Dependabot PRs all failed, and all three are major-version migrations that can't be done as a single bump: #1630 jest 28 -> 30 : test-ui fails `this._moduleMocker.clearMocksOnScope is not a function` — jest core moved ahead of its companions (jest-environment-jsdom, babel-jest still 28). #1634 @babel/core 8 : `npm ci` ERESOLVE — @babel/cli@7 and babel-jest@28 peer-require @babel/core@^7; babel 8 needs the whole babel+jest toolchain moved together. #1631 marked 4 -> 18 : marked 5+ is ESM-only and rewrote the Renderer API; its ESM loader crashes under the jest CJS env. Needs a rewrite of public/services/markdown.ts. None is a safe bump. Add semver-major ignore rules for the jest stack, the babel toolchain, and marked/@types/marked so they stop generating failing PRs each cycle. Minor/patch within the current majors still flow. Unblock by doing each as a dedicated, coordinated migration. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three new Dependabot PRs failed together (#1630, #1634, #1631). Unlike the previous batches, none is a quick win — each is a major migration entangled with others.
Why each can't just be bumped
jest28 → 30test-ui:this._moduleMocker.clearMocksOnScope is not a functionjest-environment-jsdom/babel-jest(still 28). Needs the whole jest stack + jsdom moved together, with test-behavior changes.@babel/core7 → 8npm ciERESOLVE@babel/cli@7andbabel-jest@28peer-require@babel/core@^7. Babel 8 needs@babel/cli, presets,babel-jest,babel-loaderall on 8 — and that's tied to the jest bump above.marked4 → 18test-ui: marked ESM loader throwsRendererAPI.public/services/markdown.tsusesnew marked.Renderer()+ synchronousmarked(...)— needs a rewrite.What this PR does
Adds semver-major
ignorerules for the jest stack (jest,jest-environment-jsdom,babel-jest), the babel toolchain (@babel/*,babel-loader), andmarked/@types/marked— so these stop generating failing PRs every cycle. Minor/patch within the current majors still flow. Each stays unblockable by doing it as a dedicated, coordinated migration later.This is the same land-safe / hold-blocked pattern used for playwright, tiptap-markdown, @lingui/*, and aws-sdk-go.
Follow-up
Close #1630, #1634, #1631 once this merges. (#1434 node 22→25 should also be closed — Node 25 is non-LTS; target Node 24 if/when a base bump is wanted.)
🤖 Generated with Claude Code