chore: move to container based titanoboa#66
Conversation
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull request overview
This PR migrates the Aurora ISO build pipeline to the newer container-based Titanoboa approach by building a “live build” container image that performs the ISO rootfs customization and provides image-builder configuration.
Changes:
- Add a
Containerfile+iso_files/build.shto assemble the live build environment and embed ISO image-builder config (iso_files/iso.yaml). - Update the reusable GitHub Actions workflow to build and pass a locally-built live container image into Titanoboa.
- Align flatpak list generation/cleanup paths to
iso_files/flatpaks.listand extendjust test-iso-configto validate the new script(s).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
Justfile |
Moves flatpak list output/cleanup under iso_files/ and updates syntax-check recipe to include the new build script. |
iso_files/iso.yaml |
Adds image-builder ISO label and GRUB boot entries configuration used by the new container build flow. |
iso_files/configure_iso_anaconda.sh |
Updates image ref/tag sourcing to optionally use BASE_IMAGE provided by the container-based pipeline. |
iso_files/build.sh |
New container build script to install required packages, configure live environment, and stage ISO builder config. |
Containerfile |
New container build definition that runs the ISO build script during image build. |
.github/workflows/reusable-build-iso-anaconda.yml |
Builds the live container image and passes it to Titanoboa instead of using hook/flatpak-list inputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if [[ -n "${BASE_IMAGE:-}" ]]; then | ||
| IMAGE_REF="${BASE_IMAGE%%:*}" | ||
| IMAGE_TAG="${BASE_IMAGE##*:}" |
This would make it easier to iterate locally, I think this is a really good pattern we should use here as well actually. |
Moves the ISOs to use the new container based titanoboa.
Probably not the cleanest implementation but tested on my fork and ISOs work and install correctly.
Go ham if you figure out a cleaner/better way for implementation.
We can probably get rid of the Justfile if we want to
#58