Onboarding: Board layout yields to the first-run hero#72
Merged
Conversation
Found in Phase 3 of the Refined run and deferred: #app.board-mode hides #terminal-pane, which hosts the #onboarding hero — so a user with a persisted Board layout and zero projects (fresh data dir, or deleting the last project while on the Board) saw a blank surface instead of first-run guidance. Two guards, both keyed on the same onboardingActive() state the hero already uses (zero projects, nothing attached): renderOnboarding forces the Console layout whenever the hero should show, and the title-bar Board segment refuses the switch with a "Add a project first" toast instead of navigating to an empty board. firstRun.iwft.ts adds two scenarios: the guarded Board segment, and booting with a persisted cc-layout=board falling back to Console. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sixth (last) Refined-redesign deferred item — the board-mode onboarding gap found in Phase 3.
The gap
#app.board-modehides#terminal-pane, which hosts the#onboardinghero. With zero projects and a persisted Board layout (fresh data dir, or deleting your last project while on the Board), the app showed a blank board instead of first-run guidance.What changed
renderOnboardingforces Console whenever the hero should show (onboardingActive(): zero projects, nothing attached) — covers booting into a persisted Board layout and losing the last project while on the Board.Tests
firstRun.iwft.tsscenarios: the guarded segment (toast + hero stays + Console segment active), and a persistedcc-layout=boardboot falling back to Console (localStorage seeded pre-boot via init script).npm run typecheckclean · vitest 62/62 · iwft 106/106.🤖 Generated with Claude Code