Title bar + Board: attention summary pill#71
Merged
Conversation
Audit item (Low/Discoverability, deferred from the #59-#66 stack): the one thing you most want — what's waiting on me — had no at-a-glance count. A warning-toned pill now sits in the title bar next to the session counts, and the same summary heads the Board's filter bar. Both fill from one attentionCount(): sessions whose agent asked for input (waiting) plus ones that finished while away (unread → finished), derived via sessionStateKey so the queue stays in lockstep with the status-chip vocabulary. Hidden entirely at zero — a summary, not a control. applySnapshot now updates the title-bar counts after renderBoard, since the board's pill is created with the filter bar. AppPageObject gains attentionPill() (app chrome, shared); BoardPageObject gains boardAttention(); new titlebar/attention.iwft.ts with four scenarios (hidden at zero, title-bar count, board mirror, drain via event push). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Review finding: the Hide-empty toggle rebuilds the filter bar, recreating the attention pill blank and hidden until the next poll snapshot refilled it (~2s). Call updateTitleBarCounts right after the rebuild, and assert the survival in the board scenario. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fifth Refined-redesign deferred item (audit: "'Needs review' is a section, not a signal — promote an attention summary to the title bar and the top of the Board").
What changed
N waiting on youpill next to the session counts. Hidden at zero.sessionStateKey, so the queue agrees with the status-chip vocabulary everywhere (waiting/finished are exactly the warning-hued chip states).applySnapshotnow updates title-bar counts afterrenderBoard, because the board pill is created with the filter bar on first render.Tests
AppPageObject.attentionPill()(shared chrome accessor),BoardPageObject.boardAttention(); newtitlebar/attention.iwft.tswith 4 scenarios: hidden at zero, counts waiting+unread, board mirror, clears on event-push drain.npm run typecheckclean · vitest 62/62 · iwft 108/108.🤖 Generated with Claude Code