Delete dialog: itemized consequence checklist + icon badge - #70
Merged
Conversation
Refined mockup §06 (deferred from the #59-#66 stack): the delete-session dialog swaps its centered prose for the mockup's layout — a danger-tinted ⌦ badge sits beside the "Delete session" title and mono session name, and each consequence is its own checklist line (✕ kills the agent, ✕ removes the worktree + tmux session) with equal-width Cancel / solid-danger Delete buttons below. The branch line deliberately diverges from the mockup: it renders as a green ✓ "Keeps the branch <name>" because the backend never deletes the branch (traced in #66; the mockup's "deletes the branch" line is wrong). Resolve semantics are untouched, including the Enter-on-focused-Cancel guard. Button overrides are scoped under .delete-dialog per the shared-CSS convention. deleteSessionDialog joins __CC_DIALOGS__; DialogsPageObject gains openDelete + checklist accessors; dialogs.iwft.ts adds two scenarios. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourth Refined-redesign deferred item (mockup §06 — "each irreversible effect is its own line; Cancel is the calm default; Delete is a solid-red deliberate choice").
What changed
<branch>. The ✓ branch line intentionally contradicts the mockup, which says "deletes the branch" — the backend never deletes it (traced in Refined phase 6: Kill vs Delete disambiguation + overlay normalization #66), so the truthful copy stays.--danger. Overrides scoped under.delete-dialogso the shared.confirm-buttonsis untouched.Tests
deleteSessionDialogexposed via__CC_DIALOGS__;DialogsPageObject.openDelete+ checklist accessors; 2 new dialog scenarios (checklist content incl. the truthful branch line; resolve semantics + cancel guard).npm run typecheckclean · vitest 62/62 · iwft 106/106.🤖 Generated with Claude Code