Settings: single searchable nav replaces tabs + rail - #68
Merged
Conversation
Refined mockup §06 (deferred from the #59-#66 stack): the CC-GUI / claude-commander tab strip is gone. A single nav lists every category — config ones plus the GUI-only theming, renamed Appearance and placed after General — under a Settings title and a search box that filters categories by their label or any field label/description. The panel gains an uppercase category heading, and field rows get the mockup's roomier 12px rhythm. The Appearance category keeps its live-apply localStorage behavior and its note; save_config round-tripping is untouched. SettingsModalPageObject loses selectTab and gains search()/navLabels()/ panelHeading(); settings.iwft.ts swaps the tab test for an Appearance- category one and adds three search scenarios. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Review finding: with no matching categories the nav showed "No matches" while the previously-active category kept rendering in the panel. The panel now empties with the nav; new scenario asserts both. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second Refined-redesign deferred item (mockup §06 — "collapses tabs + rail into one searchable nav with iconography; fields get 12px rhythm").
What changed
Save/Cancel semantics are untouched: config categories round-trip
save_config, Appearance applies live and never saves.Tests
SettingsModalPageObject:selectTabremoved;search(),navLabels(),panelHeading()added.settings.iwft.ts: tab test replaced with the Appearance-category equivalent; 3 new search scenarios (filter by category, filter by field label, clear restores).npm run typecheckclean · vitest 62/62 · iwft 107/107.🤖 Generated with Claude Code