The watch relay's orphans are removed: the view, the ?run= route, and the specs that still promised it - #1610
The watch relay's orphans are removed: the view, the ?run= route, and the specs that still promised it#1610suleimansh wants to merge 1 commit into
Conversation
…specs that still promised it The watch relay went in #1536 (f395f0c). Its client half stayed: RelayView, a `?run=<id>` early return in App.tsx that swapped the whole shell for it, and the `local` flag that flag threaded through three hooks to switch them off on a host that no longer exists. Nothing served any of it — the id landed in the projectId slot, resolved to nothing, and the page said "This shared session isn't available." Removing the view made two more things dead by inspection: AgentFeed's showSessionLink/showName/showStatus, always false from its one remaining caller, and the AgentOverview render they fed — with all three false it returned null every time. AgentOverview itself stays; ProjectHome uses it with its defaults. The specs that still promised the feature go with it: the root SPEC's "a shared link re-serves one agent's event stream read-only", the dashboard's Watch mode flow and its actions-menu "copy a shareable watch link", App's shared-watch-link flow, and events.SPEC.md's "the relay's own agents streaming from memory" — the last two of which were findings 1 and 4 on #1609's own list. Left alone on purpose: the device relay (#1067). `/_relay`, relay-endpoints.ts and relay-dispatch.ts are a different feature that is alive and token-guarded, and the shared word is what nearly cost the wrong deletion in #1536. Suite green: 1489 framework tests, 774 dashboard tests, typecheck clean.
|
🤖 agent comment SPEC walkthrough — nine files, each as intro + Flows, then the diff, then what it means against the rest of the file. Every change is a removal: a sentence describing the watch relay, which #1536 deleted. 1. Diff: -… the device's token is saved only in the user's own browser and handed to the local daemon per call. A shared link re-serves one agent's event stream read-only, from the same daemon that owns it. An agent can also run elsewhere: …
+… the device's token is saved only in the user's own browser and handed to the local daemon per call. An agent can also run elsewhere: …Meaning: the surfaces list is now exactly the surfaces that exist — the dashboard, a saved remote device, the cloud/Actions locations, the Chrome the agent drives, Discord. The removed sentence sat between the device relay and the remote locations, which is why it read as one of the family; it is the only member of that list with no code behind it. 2. Flows, the line that goes: Diff: that bullet is deleted outright. And in the -… an actions menu (stop, open in editor or on GitHub, remove worktree, delete it, copy a resume command, copy a shareable watch link).
+… an actions menu (stop, open in editor or on GitHub, remove worktree, delete it, copy a resume command).Meaning: the Flows bullet described a second mode the whole app could enter; there is no such mode, and the 3. -- A shared watch link renders that one agent read-only; a daemon that stops answering gets a banner, so a dead backend never looks like a quiet agent.
+- A daemon that stops answering gets a banner, so a dead backend never looks like a quiet agent.Meaning: one bullet was carrying two unrelated facts. The banner half is live and stays; the watch-link half was the page's 4. -Its pages are the Overview board, the project home/launcher, one agent's view, the cross-project tickets pages (list, per-ticket detail, per-ticket plan), Settings, a read-only shared watch view, and not-found.
+Its pages are the Overview board, the project home/launcher, one agent's view, the cross-project tickets pages (list, per-ticket detail, per-ticket plan), Settings, and not-found.Meaning: the list is the routes 5. -- An agent with no file on this host — the relay's own, or one relayed from a device — streams from memory instead.
+- An agent with no file on this host — one relayed from a device — streams from memory instead.Meaning: the flow itself is unchanged — an agent whose journal is not on this disk is served from memory. What changes is how many sources that covers: one, the device relay (#1067). This was finding 2 on #1609's own contradiction list; it is closed here at the source. 6. -The agent-overview cards projected from the event stream — the status line and an honestly-labelled link to the live session — each rendered only once its data has arrived, with embedding views opting out of the parts their own chrome already shows.
+The agent-overview cards projected from the event stream — the status line and an honestly-labelled link to the live session — each rendered only once its data has arrived.Meaning: the opting-out clause described three flags ( 7. -The tab icon follows the work: the still logo while nothing is running, the animated one while an agent is working — and a view that cannot know (the relay) leaves the icon alone.
+The tab icon follows the work: the still logo while nothing is running, the animated one while an agent is working.Meaning: the hook had an 8. -- Localhost-only: with no checkout to list (the relay), the tree renders nothing.
+- With no checkout to list, the tree renders nothing.Meaning: the behavior is unchanged and still reachable — the parenthetical named the relay as the case that produced it, and that is no longer the reason. The empty-tree path stays. 9. -Covers the liveness probe: an answering daemon reads healthy, a failing one flips to down, and the shared watch view (which has no daemon of its own) never probes.
+Covers the liveness probe: an answering daemon reads healthy, and a failing one flips to down.Meaning: the third case tested the
|
|
🤖 agent comment Superseded by #1611, which does this cleanup and much more (the website copy bug and the 13 spec-drift findings). Closing this in favour of it — no need to review it. Recording the two things #1611 leaves behind, so they are not lost: Dead code the relay's removal created. A dead parameter rather than a defaulted one. #1611 has Four specs still carrying relay clauses that #1611 does not touch: All of it is removal of code nothing can reach, so nothing is lost by it landing later. Will pick it up as a small follow-up once #1611 is in. |
1 participant
🤖 agent PR
Follow-up to #1609, which deliberately left these for this pass ("the stale flow sentences stay preserved for the queued relay-orphan cleanup", b560f9d).
What the user sees. Nothing changes. That is the point — every line removed here was already unreachable.
The watch relay was deleted in #1536 (
f395f0c1), but its client half stayed on main:RelayView, a?run=<id>early return inApp.tsxthat swapped the whole shell for it, and alocalflag threaded throughuseWorking/useDaemonHealth/useFaviconpurely to switch them off on a host that no longer exists. Nothing served any of it: the id landed in theprojectIdslot, resolved to nothing, and the page said "This shared session isn't available."Two things were dead by inspection once the view went.
AgentFeed'sshowSessionLink/showName/showStatuswere alwaysfalsefromAgentView, its one remaining caller — and with all three false theAgentOverviewthey fed hitif (!sessionLink && !status) return nullevery time. Both go.AgentOverviewitself stays:ProjectHomerenders it with its defaults, where it shows something.The specs that still promised the feature go too:
SPEC.md— "A shared link re-serves one agent's event stream read-only, from the same daemon that owns it"dashboard/SPEC.md— the "Watch mode" flow, and the actions menu's "copy a shareable watch link" (AgentActionsMenu.tsxoffers Copy resume command / Copy session id and never offered this)dashboard/App.SPEC.md— the shared-watch-link flow, keeping its daemon-banner halfdashboard/components/SPEC.md— "a read-only shared watch view" in the shell's page listsrc/dashboard-rpc/events.SPEC.md— "the relay's own agents streaming from memory"AgentOverview.SPEC.md,favicon.SPEC.md,FileTree.SPEC.md,use-daemon-health.test.SPEC.md— the clauses describing what the relay opted out ofThe last of those were findings on #1609's own contradiction list, closed here at the source rather than one spec at a time.
Left alone on purpose: the device relay (#1067).
/_relay,relay-endpoints.tsandrelay-dispatch.tsare a live, token-guarded feature that happens to share the word. Cutting on the name rather than on what the module does is exactly what nearly went wrong in #1536.FEATURES-SPEC.mdneeds no edit — the watch link was never listed there, which is part of how the stale specs went unnoticed.Tests. Suite green: 1489 framework, 774 dashboard, typecheck clean. The two tests that only existed to prove the relay's opt-outs (
useFavicon(true, false), "disabled (the relay) never probes") are removed with the parameters they tested; every other test is untouched and still passes, which is the check that nothing user-visible moved.All nine edited specs were verified against the new
sdd.mdtemplate — allowed sections only, correct order, byte-exact footer.