Skip to content

Refactor list_distances.py for better structure #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
garyarzuma wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor list_distances.py for better structure #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 14 additions & 19 deletions 2024/1/list_distances.py
View file
Open in desktop

@garyarzuma garyarzuma Dec 18, 2025

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great refactoring! The encapsulation of the logic into a main() function is much cleaner and follows Python best practices. The use of descriptive variable names like left_values and right_values makes the code self-documenting.

Original file line number Diff line number Diff line change
@@ -1,26 +1,21 @@
import fileinput
import fileinput

list1 = [];
list2 = [];

for line in fileinput.input(files='input', encoding="utf-8"):
list = line.rstrip().partition(' ')
list1.append(list[0])
list2.append(list[2])
def main():
left_values = []
right_values = []

list1.sort()
list2.sort()
for line in fileinput.input(files="input", encoding="utf-8"):
left, right = line.split()
left_values.append(int(left))
right_values.append(int(right))

listSums = [];
left_values.sort()
right_values.sort()

for x in range(len(list1)):
listSums.append(abs(int(list1[x]) - int(list2[x])))

distance = 0;

for num in listSums:
distance += num;

print(distance)
distance = sum(abs(a - b) for a, b in zip(left_values, right_values))
print(distance)


if __name__ == "__main__":
main()