fix:Fix required OpenAPI drift for Reimbursement#829
Merged
Conversation
yashUkalkar
approved these changes
Jul 22, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the OpenAPI schema for Reimbursements to resolve drift by explicitly declaring required fields, and regenerates the bundled admin reference spec so downstream docs/mocks reflect the updated contract.
Changes:
- Added an explicit
requiredlist toreimbursement_outto define mandatory response fields. - Marked
idas required inreimbursement_in_minimal(used by reimbursement “mark complete/paid” operations). - Regenerated
reference/admin.yamlto include the updated component schema.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/components/schemas/reimbursement.yaml | Adds required constraints for reimbursement output and minimal input schemas to match intended contract. |
| reference/admin.yaml | Updates the bundled admin OpenAPI reference to reflect the schema changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please add PR description here, add screenshots if needed
Clickup
app.clickup.com