Fixed ls() bug when files have the same prefix - #549
Merged
Conversation
Member
|
@shcheklein , maybe? @anjaliratnam-msft , was there a reason this stalled? |
Collaborator
Author
|
Hi @martindurant. Yeah, after taking a look at it again and talking to some team members, there's some changes I want to make to the PR today. Mainly just moving the logic to |
Member
|
Perfect, thank you. |
anjaliratnam-msft
force-pushed
the
ls-bug
branch
from
August 7, 2026 23:38
93fa52a to
38254ea
Compare
kyleknap
reviewed
Aug 10, 2026
kyleknap
left a comment
kyleknap
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! I just had a couple of comments.
kyleknap
reviewed
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses a bug where a filepath is passed into
ls()and it shares the same prefix as other files in the same directory resulting in incorrect results. This resolves #406 and resolves #409.