feat(core/stratum): per-session doa_shares_ DOA counter (split from #665)#666
Merged
Merged
Conversation
…-changed submit Split out of #665 (threetier wirecompat harness) per the integrator scope ruling: src/core is the shared exceptional-only lane, so this prod-accounting change must travel as its own reviewable diff rather than ride a test-harness PR. Increments doa_shares_ in StratumSession::handle_submit when the block template changed between job issue and submit (live-vs-frozen prevhash mismatch). Accounting only: the share is still created and broadcast (matches p2pool); no PPLNS/consensus path touched. NOTE: counter is currently write-only (no dashboard consumer yet). Requires an explicit justification + all four coin smokes green before merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #665 per the integrator scope ruling (test-harness PR must not carry a shared-
src/coreprod change).What
Increments a new per-session
doa_shares_counter inStratumSession::handle_submiton the block-template-changed path (live-vs-frozen prevhash mismatch at submit).accepted_/rejected_/stale_shares_session stat members.Scope justification (src/core = shared exceptional-only lane)
Per-session DOA visibility for the crossing-soak dashboards. Isolated to
StratumSessionstat members; no coin-specific consensus, no isolation-primitive (prefix/id) touched.Honest caveats for the reviewer
Not in this diff
The SPDX AGPL headers and the no-trailing-newline state on both files are already on
masterfrom relicense #658 — they are not introduced here.git diff github/master...03e3a6eb -- src/core/stratum_server.*shows only the twodoa_shares_lines.GPG: signed, key 50AB1379285EFE76.