feat(menu): notify icon and runtime props to menu items - #313
Draft
kabaniery wants to merge 1 commit into
Draft
Conversation
kabaniery
force-pushed
the
306_addNotifyIcon
branch
from
July 1, 2026 14:17
2215b0b to
4063591
Compare
y9san9
reviewed
Jul 6, 2026
| const {pathname} = useLocation(); | ||
|
|
||
| const backend = useBackend(); | ||
| const feedQuery = useQuery({ |
Member
There was a problem hiding this comment.
if we do that request here, we should not repeat it on the tab page as well, I think.
Currently we invoke request 2 times, so user have to wait until feed is loaded even tho it was already loaded for notification.
You can create an issue on that and we will merge PR without fixing it instantly, we just need to remember that.
y9san9
approved these changes
Jul 6, 2026
kotleni
requested changes
Jul 6, 2026
| title: string; | ||
| icon: ReactNode; | ||
| releaseTag?: string; | ||
| hasNotify?: boolean; |
Collaborator
There was a problem hiding this comment.
It's a bit overcomplicated way to do so.
It's could be better to have async callback instead of hasNotify Boolean.
Collaborator
There was a problem hiding this comment.
- 'Ui' folder is reserved for Shadcn components, you shouldn't put it there.
kotleni
marked this pull request as draft
July 6, 2026 07:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#306