ci: build x86_64-apple-darwin on Apple Silicon (macos-13 retired)#378
Open
sanity wants to merge 1 commit into
Open
ci: build x86_64-apple-darwin on Apple Silicon (macos-13 retired)#378sanity wants to merge 1 commit into
sanity wants to merge 1 commit into
Conversation
The first tagged release (riverctl-v0.1.72) got stuck: verify + 3/4 binary builds succeeded, but the x86_64-apple-darwin job sat queued ~11.5h because GitHub is retiring the Intel `macos-13` runner and no longer allocates it. crates.io was NOT published — publish-crates is gated on build-binaries, so the stuck build correctly blocked the release (no half-release). Fix: build BOTH macOS targets on `macos-latest` (Apple Silicon); x86_64 is cross-compiled from arm64 via the existing `rustup target add` + `cargo build --target` step. This removes the dependency on the retired Intel runner while keeping Intel-mac binary coverage. Note: the release workflow only runs on tags, so this cross-compile leg is first exercised by the re-tagged run, not by PR CI. It fails safe — if a dep doesn't cross-compile, build-binaries fails and nothing publishes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WXwdRyFMf8Qfzx8RVp8FFF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The first tagged release (
riverctl-v0.1.72, run 28677460838) got stuck:verify+ 3 of 4 binary builds (linux, arm64 macOS, windows) succeeded, butx86_64-apple-darwinonmacos-13sat queued ~11.5h — GitHub is retiring the Intelmacos-13runner and no longer allocates it.No half-release occurred:
publish-cratesis gated onbuild-binaries, so the stuck Intel build correctly blocked the crates.io publish. Nothing was published under 0.1.72. (This validated the review's build-before-publish ordering.)Fix
Build both macOS targets on
macos-latest(Apple Silicon).x86_64-apple-darwinis cross-compiled from arm64 via the existingrustup target add+cargo build --targetstep — no native Intel runner needed. Keeps Intel-mac binary coverage.Caveat
The release workflow only runs on tags, so PR CI does not exercise this cross-compile leg — it's first tested by the re-tagged run. It fails safe: if a dependency doesn't cross-compile to x86_64 from arm64,
build-binariesfails and nothing publishes. Fallback if it fails: drop thex86_64-apple-darwintarget (ship arm64 macOS + linux + windows) and add it back later.To complete the release after merge
Re-point the (unconsumed) tag to the fixed commit:
[AI-assisted - Claude]