Skip to content

Add warning icon to alerts#26

Open
Muaz-T wants to merge 1 commit into
certfrom
add-warning-icon-to-alerts
Open

Add warning icon to alerts#26
Muaz-T wants to merge 1 commit into
certfrom
add-warning-icon-to-alerts

Conversation

@Muaz-T

@Muaz-T Muaz-T commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Just added a small triangle to the alert menu, I agree the small one looks better

@Muaz-T Muaz-T requested a review from AlexKempen July 9, 2026 19:08
@AlexKempen AlexKempen force-pushed the add-warning-icon-to-alerts branch from 1488d7d to 81527f4 Compare July 12, 2026 22:14

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can probably use IconColor.YELLOW

@AlexKempen

Copy link
Copy Markdown
Collaborator

The vertical spacing of the icon looks a little wonky (up and down), I asked Claude and it said to do something ridiculous with CSS (lol), so I think the best and easiest solution is to just add a bit of margin top (mt) to the icon, e.g., mt={4}

image image

@AlexKempen AlexKempen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments, just two minor tweaks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants