[AISOS-2199] Task takeover workflow does not transition Jira ticket status after PR merge

[ekuris-redhat]

Summary

This pull request resolves a critical gap in the task takeover workflow by ensuring that Jira tickets are properly transitioned and labeled when a task is completed after a pull request merge. Previously, the workflow updated only internal states, leaving the ticket status out-of-sync in Jira. With this fix, completed takeover tickets are automatically closed and labeled as approved, ensuring state consistency across systems and reducing manual overhead for developers.

Changes

Workflows

• src/forge/workflow/task_takeover/graph.py: Updated the complete_task_takeover function to initialize a JiraClient, transition the completed task takeover ticket to JiraStatus.CLOSED, and set the workflow label to ForgeLabel.TASK_REVIEW_APPROVED.
• Integrated error resilience patterns matching other human-review nodes, wrapping the Jira operations in a try-except block to prevent external Jira failures from crashing the core execution workflow, and ensuring the JiraClient is safely closed in a finally block.

Testing

• tests/workflow/test_task_takeover_graph.py: Introduced unit tests to validate the updated complete_task_takeover node, testing successful ticket closure and label application, as well as testing that exceptions raised during Jira operations are safely logged as warnings and do not interrupt execution.

Implementation Notes

• Resilience over Rigidity: In line with the pattern in complete_tasks inside src/forge/workflow/nodes/human_review.py, Jira transition failures are treated as non-fatal. They are logged as warnings rather than raising exceptions, ensuring that a temporary network issue with the Jira API does not block or fail the entire workflow.
• Resource Management: A standard try-finally block was employed to guarantee that JiraClient.close() is always executed, avoiding leaked HTTP connections or sessions.

Testing

• Unit Testing: Added unit tests confirming that complete_task_takeover makes the appropriate transition_issue and set_workflow_label calls with the expected arguments.
• Error Handling Verification: Simulated API failure scenarios to ensure exceptions thrown during the Jira lifecycle are caught, logged, and gracefully bypassed without disrupting workflow termination.

Related Tickets

• AISOS-2199
• GH-issue-156

---

Generated by Forge SDLC Orchestrator

[ekuris-redhat]

Tested locally:

1. Ran full unit test suite : 1465 passed, no regressions
2. Triggered a fresh task takeover workflow on AISOS-2206
3. Workflow completed through PR merge
4. After merge, complete_task_takeover transitioned the Jira ticket to Closed/Done and set the forge:review-approved label

Before this fix, the ticket status remained unchanged after PR merge.

[eshulman2]

is this file needed?

[ekuris-redhat]

Forge is addressing PR review feedback now. This status update is informational.