Skip to content

Route local review feedback through implementation#121

Open
eshulman2 wants to merge 1 commit into
mainfrom
forge/review-loop-graph
Open

Route local review feedback through implementation#121
eshulman2 wants to merge 1 commit into
mainfrom
forge/review-loop-graph

Conversation

@eshulman2

Copy link
Copy Markdown
Collaborator

Summary

  • make local review read-only and discard accidental reviewer edits
  • route failed feature review back to implementation for a dedicated feedback-fix pass
  • add implementation prompt and tests for capped review loops across feature and bug workflows

Tests

  • uv run pytest tests/unit/workflow/nodes/test_local_reviewer.py tests/unit/workflow/nodes/test_implementation.py tests/unit/workflow/nodes/test_local_review_pass_tracking_errors.py tests/unit/workflow/nodes/test_local_review_status_comments_comprehensive.py tests/flows/bug_workflow/test_complete_bug_flow.py tests/unit/workflow/bug/test_graph.py tests/unit/workflow/feature/test_workflow.py tests/unit/prompts/test_prompt_templates.py -q
  • uv run ruff check src/forge/workflow/nodes/local_reviewer.py src/forge/workflow/nodes/implementation.py src/forge/workflow/feature/graph.py src/forge/workflow/feature/state.py src/forge/workflow/bug/graph.py tests/unit/workflow/nodes/test_local_reviewer.py tests/unit/workflow/nodes/test_local_review_pass_tracking_errors.py tests/unit/workflow/nodes/test_local_review_status_comments_comprehensive.py tests/unit/workflow/nodes/test_implementation.py tests/flows/bug_workflow/test_complete_bug_flow.py tests/unit/workflow/bug/test_graph.py tests/unit/workflow/feature/test_workflow.py tests/unit/prompts/test_prompt_templates.py

@eshulman2 eshulman2 added bug Something isn't working area:workflow Workflow graphs, orchestration, state, routing, and gates area:agents Agents, prompts, models, skills, and generated artifacts ready-for-review labels Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:agents Agents, prompts, models, skills, and generated artifacts area:workflow Workflow graphs, orchestration, state, routing, and gates bug Something isn't working ready-for-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant