Added ability to change <input> to <textarea> from a boolean flag#87
Merged
Conversation
Contributor
Author
|
@fmoo What feedback do you want? |
Owner
|
Just curious what other folks following the project think of this change, will it break them or their plans, etc.
|
Contributor
Author
|
@fmoo Nothing breaks there, it's just a completely optional prop that allows a bit more flexibility. And I don't mind it being removed when #34 gets merged in as they serve the same purpose (though my PR is in a much more limited scope). |
Owner
|
Can you add a description of the feature to README.md ? |
Contributor
Author
|
@fmoo Done! Feel free to ask for anything else. Have a great day! |
fmoo
added a commit
that referenced
this pull request
Jul 12, 2015
Added ability to change <input> to <textarea> from a boolean flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
As I said before, I needed this kind of simple functionality.
I know it is kinda a duplicate with #34, but the aim is much simpler, implications are much smaller, and it would fit 90% of usages for this.
Unit tests are included also, and are all passing.