Skip to content

docs: clarify xcconfig file usage and simplify notes in iOS flavors guide - #13748

Merged
lamek merged 4 commits into
flutter:mainfrom
lamek:ticket-542694934-issue-12225
Aug 20, 2026
Merged

docs: clarify xcconfig file usage and simplify notes in iOS flavors guide#13748
lamek merged 4 commits into
flutter:mainfrom
lamek:ticket-542694934-issue-12225

Conversation

@lamek

@lamek lamek commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Clarifies the iOS flavors guide to explain that both Profile and Release build configurations use Release.xcconfig by default, resolving confusion about a non-existent Profile.xcconfig file.

Moved both notes (existing note and my new one) to inline instructions. This is to avoid stacked callouts at the end of the procedure, or mid-list callouts.

Fixes #12225

Presubmit checklist

  • If you are unwilling, or unable, to sign the CLA, even for a tiny, one-word PR, please file an issue instead of a PR.
  • If this PR is not meant to land until a future stable release, mark it as draft with an explanation.
  • This PR follows the Google Developer Documentation Style Guidelines—for example, it doesn't use i.e. or e.g., and it avoids I and we (first-person pronouns).
  • This PR uses semantic line breaks
    of 80 characters or fewer.

@lamek
lamek requested review from a team and sfshaza2 as code owners August 18, 2026 23:29

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the iOS Flutter flavors documentation to improve readability, refine phrasing, and clarify the default behavior of Xcode build configurations. The review feedback suggests reverting the relocation of the lowercase scheme name requirement note, as placing it inline under the staging configuration incorrectly implies it only applies to staging. Instead, the reviewer recommends combining it with the general configuration note block to ensure it remains applicable to all configurations.

Comment thread sites/docs/src/content/deployment/flavors-ios.md Outdated
Comment thread sites/docs/src/content/deployment/flavors-ios.md Outdated
@flutter-website-bot

flutter-website-bot commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Staged preview of the updated docs.flutter.dev site (updated for commit 9bbb8eb):

https://flutter-docs-prod--docs-pr13748-ticket-542694934-issue-5pskfpz6.web.app

@lamek
lamek requested a review from MuthuGCodes August 18, 2026 23:44
@lamek

lamek commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

@MuthuGCodes please take a look and ping @sfshaza2 after you've had a chance to review.

@flutter-website-bot

flutter-website-bot commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Staged preview of the updated flutter.dev site (updated for commit 9bbb8eb):

https://flutter-dev-230821--www-pr13748-ticket-542694934-issue-7xntudor.web.app

@sfshaza2 sfshaza2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve, but please stop using "see" (and it's pretty excessive in this doc).

@lamek

lamek commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @sfshaza2. I cleaned up the other instances in this doc.

@lamek
lamek merged commit a589dc3 into flutter:main Aug 20, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

in xcode Profile.xcconfig doesn't exist

3 participants