docs: clarify xcconfig file usage and simplify notes in iOS flavors guide - #13748
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the iOS Flutter flavors documentation to improve readability, refine phrasing, and clarify the default behavior of Xcode build configurations. The review feedback suggests reverting the relocation of the lowercase scheme name requirement note, as placing it inline under the staging configuration incorrectly implies it only applies to staging. Instead, the reviewer recommends combining it with the general configuration note block to ensure it remains applicable to all configurations.
|
Staged preview of the updated docs.flutter.dev site (updated for commit 9bbb8eb): https://flutter-docs-prod--docs-pr13748-ticket-542694934-issue-5pskfpz6.web.app |
|
@MuthuGCodes please take a look and ping @sfshaza2 after you've had a chance to review. |
|
Staged preview of the updated flutter.dev site (updated for commit 9bbb8eb): https://flutter-dev-230821--www-pr13748-ticket-542694934-issue-7xntudor.web.app |
sfshaza2
left a comment
There was a problem hiding this comment.
I'll approve, but please stop using "see" (and it's pretty excessive in this doc).
|
Thanks @sfshaza2. I cleaned up the other instances in this doc. |
Clarifies the iOS flavors guide to explain that both Profile and Release build configurations use
Release.xcconfigby default, resolving confusion about a non-existentProfile.xcconfigfile.Moved both notes (existing note and my new one) to inline instructions. This is to avoid stacked callouts at the end of the procedure, or mid-list callouts.
Fixes #12225
Presubmit checklist
of 80 characters or fewer.