docs: use safe casts in Android Gradle signing configuration - #13743
docs: use safe casts in Android Gradle signing configuration#13743lamek wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request refines the Android deployment documentation by improving phrasing, punctuation, and formatting, as well as updating a Kotlin Gradle configuration snippet to use safe casts (as? String) instead of unsafe casts. The reviewer suggests a further improvement to use the standard getProperty(key) method on the Properties object, which is more idiomatic and avoids the need for casting.
|
Staged preview of the updated docs.flutter.dev site (updated for commit ce4b2f4): https://flutter-docs-prod--docs-pr13743-ticket-542694649-issue-3x37sphp.web.app |
|
Staged preview of the updated flutter.dev site (updated for commit ce4b2f4): https://flutter-dev-230821--www-pr13743-ticket-542694649-issue-f13zl06g.web.app |
|
Please use a more descriptive title for the PR. thx |
…h apkanalyzer phrasing
8bf402d to
ce4b2f4
Compare
|
@sfshaza2 updated with your feedback. Thanks for the review. |
Updates the Android
build.gradle.ktsrelease signing example to use safe casts (as? String) instead of unsafe casts (as String). This prevents Gradle configuration from crashing on debug builds whenkey.propertiesis absent.Fixes #11995
Presubmit checklist
of 80 characters or fewer.