Skip to content

docs: use safe casts in Android Gradle signing configuration - #13743

Open
lamek wants to merge 4 commits into
flutter:mainfrom
lamek:ticket-542694649-issue-11995
Open

docs: use safe casts in Android Gradle signing configuration#13743
lamek wants to merge 4 commits into
flutter:mainfrom
lamek:ticket-542694649-issue-11995

Conversation

@lamek

@lamek lamek commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Updates the Android build.gradle.kts release signing example to use safe casts (as? String) instead of unsafe casts (as String). This prevents Gradle configuration from crashing on debug builds when key.properties is absent.

Fixes #11995

Presubmit checklist

  • If you are unwilling, or unable, to sign the CLA, even for a tiny, one-word PR, please file an issue instead of a PR.
  • If this PR is not meant to land until a future stable release, mark it as draft with an explanation.
  • This PR follows the Google Developer Documentation Style Guidelines—for example, it doesn't use i.e. or e.g., and it avoids I and we (first-person pronouns).
  • This PR uses semantic line breaks
    of 80 characters or fewer.

@lamek
lamek requested review from a team and sfshaza2 as code owners August 18, 2026 21:58

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refines the Android deployment documentation by improving phrasing, punctuation, and formatting, as well as updating a Kotlin Gradle configuration snippet to use safe casts (as? String) instead of unsafe casts. The reviewer suggests a further improvement to use the standard getProperty(key) method on the Properties object, which is more idiomatic and avoids the need for casting.

Comment thread sites/docs/src/content/deployment/android.md Outdated
@flutter-website-bot

flutter-website-bot commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Staged preview of the updated docs.flutter.dev site (updated for commit ce4b2f4):

https://flutter-docs-prod--docs-pr13743-ticket-542694649-issue-3x37sphp.web.app

@flutter-website-bot

flutter-website-bot commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Staged preview of the updated flutter.dev site (updated for commit ce4b2f4):

https://flutter-dev-230821--www-pr13743-ticket-542694649-issue-f13zl06g.web.app

@sfshaza2

Copy link
Copy Markdown
Contributor

Please use a more descriptive title for the PR. thx

@lamek lamek changed the title Fix for ticket 542694649 (GitHub issue #11995) docs: use safe casts in Android Gradle signing configuration Aug 18, 2026
Comment thread sites/docs/src/content/deployment/android.md Outdated
Comment thread sites/docs/src/content/deployment/android.md Outdated
Comment thread sites/docs/src/content/deployment/android.md Outdated
@lamek
lamek force-pushed the ticket-542694649-issue-11995 branch from 8bf402d to ce4b2f4 Compare August 19, 2026 16:34
@lamek

lamek commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

@sfshaza2 updated with your feedback. Thanks for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Play Store signing config with gradle kts fails in debug mode

4 participants