Add iframe vs DOM embedding comparison - #13739
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Flutter web embedding documentation by adding a comparison table between iframe and direct DOM embedding, as well as detailing the mandatory CSS requirements for host elements. The review feedback suggests clarifying that sharing a single engine instance across multiple views is specific to multi-view mode, and recommends avoiding references to internal engine class names in user-facing documentation.
|
Staged preview of the updated docs.flutter.dev site (updated for commit 9ef078c): https://flutter-docs-prod--docs-pr13739-web-embedding-docs-n07lu0c9.web.app |
harryterkelsen
left a comment
harryterkelsen
left a comment
There was a problem hiding this comment.
Mostly LGTM but the comment about inheriting CSS from the host page isn't exactly right. All the styling in Flutter apps happens with Flutter widgets, we don't use CSS
|
Staged preview of the updated flutter.dev site (updated for commit 9ef078c): https://flutter-dev-230821--www-pr13739-web-embedding-docs-0qlgwxqs.web.app |
5 participants
Fixes #13621