Add docs on 'Create app flavors for Windows and Linux' - #13736
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new documentation guide for setting up Flutter flavors on Windows and Linux desktop apps, along with updating existing docs and navigation links to reference it. Feedback on the new guide highlights a critical MDX syntax error with an unclosed <Tabs> tag, and suggests providing more concrete, actionable CMake and configuration examples for customizing application icons on both Windows and Linux.
| 1. Configure `windows/runner/Runner.rc` or your CMake target | ||
| to use `APP_ICON_NAME` for the application icon resource. |
There was a problem hiding this comment.
This step is currently very vague and does not explain how to configure Runner.rc or the CMake target to use APP_ICON_NAME. Since configuring resource files with dynamic CMake variables can be non-trivial for users, please provide a concrete example or a brief explanation of how to achieve this (for example, using configure_file in CMake to generate Runner.rc from a template).
| 1. Update `linux/CMakeLists.txt` to install the correct `.desktop` file | ||
| and icon based on `FLUTTER_APP_FLAVOR`. |
There was a problem hiding this comment.
Similar to the Windows icon customization step, this instruction is very high-level and does not provide a concrete CMake snippet showing how to conditionally install the .desktop file and icon. Providing a brief example would make this guide much more actionable and user-friendly.
|
Staged preview of the updated docs.flutter.dev site (updated for commit 76814d8): https://flutter-docs-prod--docs-pr13736-flavors-windows-linux-xianrw9y.web.app |
|
@AngeloAvv, can you help with a review? The bot is suggesting a more detailed description and I could use some help. |
|
Staged preview of the updated flutter.dev site (updated for commit 7656651): https://flutter-dev-230821--www-pr13736-flavors-windows-linux-6b9jzi0s.web.app |
|
@sfshaza2 sure! I'll take a look in the upcoming days |
3 participants
Closes #13642
Adds documentation for setting up app flavors on Windows and Linux desktop platforms.