fix(ci): skip E2E tests when REPO_GEMINI_API_KEY is not set#972
Open
gspencergoog wants to merge 1 commit into
Open
fix(ci): skip E2E tests when REPO_GEMINI_API_KEY is not set#972gspencergoog wants to merge 1 commit into
gspencergoog wants to merge 1 commit into
Conversation
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
polina-c
reviewed
Jun 16, 2026
| # Do not run on forked branches, | ||
| # because the test does not have access to secrets in forks. | ||
| if: github.repository == 'flutter/genui' | ||
| if: github.repository == 'flutter/genui' && secrets.REPO_GEMINI_API_KEY != '' |
Collaborator
There was a problem hiding this comment.
How about leaving just second condition so that forks can have key configured and test running?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Only run the E2E test job in the eval workflow if the
REPO_GEMINI_API_KEYsecret is not empty. This avoids workflow failures on branch pushes from Dependabot, which does not have access to repository secrets.Changes
eval-jobconditional in.github/workflows/e2e.yamlto includesecrets.REPO_GEMINI_API_KEY != ''.Impact & risks
There are no risks. On Dependabot runs, the E2E job will be skipped, which satisfies required status checks. It will continue to run as expected on collaborator pushes and scheduled runs.
Testing