fix(tests): canonicalize indexing-route fixture for 8.3 short-name CI runners - #209
Merged
Merged
Conversation
… runners indexing_route_answers_json (PR #203) was green locally but red on the Windows CI runner: ReposConfig::register canonicalizes before storing (repos.rs L437), while the /indexing query used the raw tempdir path — on CI the temp root sits under an 8.3 short name (RUNNER~1) that only canonicalize resolves, so covered=false and the assert failed. Same trap and same fix as remove_order_tests' make_proj (PR #197). Note: the embed::cache panic line in the same CI log is the INTENTIONAL caught panic ("simulated mid-test failure") inside catch_unwind — log noise, that test passes.
flupkede
added
the
no-changelog
flupkede
pushed a commit
that referenced
this pull request
Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only real test-windows CI failure since PR #203 landed: indexing_route_answers_json queried /indexing with the raw tempdir path while register canonicalizes before storing — on GitHub's Windows runners the temp root is an 8.3 short name (RUNNER~1), so covered=false and the assert failed (green locally, red on CI). Fix mirrors remove_order_tests' make_proj (PR #197 precedent): safe_canonicalize the fixture before registering/querying. The embed::cache 'panic' in the same logs is the intentional caught panic inside catch_unwind — noise, test passes.