Skip to content

Clarity for controls - #735

Merged
lawsie merged 5 commits into
flipcomputing:mainfrom
lawsie:clarity-for-controls
Aug 4, 2026
Merged

Clarity for controls#735
lawsie merged 5 commits into
flipcomputing:mainfrom
lawsie:clarity-for-controls

Conversation

@lawsie

@lawsie lawsie commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Change player control panel to document R, E, F, Space as button triggers, and to document that buttons 1-4 can be bound
  • Add information string for orbit gizmo to clarify controls
  • Alter fly cam info string to give Mac controls too

AI usage

Claude Sonnet 5 and Haiku 4.5 used throughout, plans made by me.

Summary by CodeRabbit

  • New Features
    • Player controls now show keyboard shortcuts and corresponding controller buttons.
    • Camera instructions include additional Page Up/Down and Fn-based controls.
    • Orbit and eye gizmos now display clearer status information when attached or selected.
  • Localization
    • Added or updated player-control panel translations across supported languages.
  • Style
    • Improved keyboard shortcut alignment and sizing for clearer presentation.
  • Bug Fixes
    • Control panel headers remain visible while scrolling through on-screen controls.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@lawsie, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a7d09abf-d20d-4bbd-b743-e7a78c766572

📥 Commits

Reviewing files that changed from the base of the PR and between efbf254 and e7f9990.

📒 Files selected for processing (7)
  • accessibility/keyboardui.js
  • locale/de.js
  • locale/fr.js
  • locale/it.js
  • locale/pl.js
  • locale/pt.js
  • locale/sv.js
📝 Walkthrough

Walkthrough

The player controls UI now displays keyboard bindings, translated titles, controller mappings, and updated camera instructions across supported locales. Key styling was refined. Eye-gizmo cleanup and activation now update orbit status messages.

Changes

Player controls UI

Layer / File(s) Summary
Player controls display
accessibility/keyboardui.js
The player panel uses its translated title, displays R, E, F, and Space bindings, keeps the section header visible, and preserves scrolling behavior.
Localized control labels
locale/*.js, style.css
Supported locales add player-control labels and updated camera instructions. PC key styling centers and sizes keyboard keys consistently.

Eye-gizmo status handling

Layer / File(s) Summary
Orbit status lifecycle
ui/gizmos.js
Eye-gizmo cleanup clears status text. Eye-gizmo activation displays orbit mesh information for selected or newly picked meshes.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested reviewers: tracygardner, claude

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and relates to the documented control improvements, but it does not identify the specific controls or documentation changes.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@accessibility/keyboardui.js`:
- Around line 1199-1210: Update renderControl in the entry.marks branch so the
sr-only accessible text includes entry.keys when present, alongside entry.label;
preserve the current label-only output when no keys exist and keep the visual
aria-hidden markup unchanged.

In `@locale/de.js`:
- Around line 1224-1242: Add the missing Player panel key-label translations to
each locale file. The keys player_decrease_font_size, player_increase_font_size,
gamepad_left_stick, gamepad_right_stick, gamepad_l1_r1, gamepad_triangle_y,
gamepad_square_x, gamepad_circle_b, gamepad_cross_a, dpad_up, dpad_down, and
dpad_left are referenced by accessibility/keyboardui.js but not defined in these
locale objects, causing fallback to English. Add these translations in the
Player panel section at locale/de.js lines 1224-1242, locale/fr.js lines
1231-1250, locale/it.js lines 1233-1252, locale/pl.js lines 1225-1244,
locale/pt.js lines 1236-1254, and locale/sv.js lines 1211-1229.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 12635010-f981-40dc-adcb-28c465d20072

📥 Commits

Reviewing files that changed from the base of the PR and between bf334d9 and efbf254.

📒 Files selected for processing (11)
  • accessibility/keyboardui.js
  • locale/de.js
  • locale/en.js
  • locale/es.js
  • locale/fr.js
  • locale/it.js
  • locale/pl.js
  • locale/pt.js
  • locale/sv.js
  • style.css
  • ui/gizmos.js

Comment thread accessibility/keyboardui.js Outdated
Comment thread locale/de.js
@lawsie
lawsie merged commit 4fe5845 into flipcomputing:main Aug 4, 2026
3 checks passed
@lawsie
lawsie deleted the clarity-for-controls branch August 4, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant