EDM-4888: Enable the restart action on success - #762
Open
celdrake wants to merge 1 commit into
Open
Conversation
Made-with: Cursor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
WalkthroughThe lifecycle utilities now define restart timeout handling and recognize completed start actions. The lifecycle hook clears pending restart state after 500 ms. The lifecycle error alert title now states that the requested action failed. ChangesApplication lifecycle action handling
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the user attempts to "Restart" an already started application, the Backend just signals the intent with a new annotation called
restartGeneration, and there is no observable field in status (or the annotation itself) that can be used to understand when the action is in progress or finished.Given this, we clear the action after an arbitrary timeout to signal that the action has been received and was triggered.
Summary
libs/ui-components/lifecycle handling.RESTART_PENDING_TIMEOUT_MStimeout when the backend provides no completion status.Completed.libs/types/,libs/i18n/,libs/cypress/, app-specific code, the Go auth proxy, container builds, E2E tests, or CI configuration.