EDM-4987: Do not send wrong bytes that causes the session logout - #760
Open
celdrake wants to merge 1 commit into
Open
EDM-4987: Do not send wrong bytes that causes the session logout#760celdrake wants to merge 1 commit into
celdrake wants to merge 1 commit into
Conversation
WalkthroughThe WebSocket hooks now encode regular messages with Kubernetes channel framing. Resize messages return without transmission. The unused ChangesKubernetes WebSocket channel framing
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Made-with: Cursor
celdrake
force-pushed
the
bugfix/EDM-4987-vm-console-resize-ctrl-d
branch
from
August 6, 2026 07:36
9a77ad4 to
d1c0677
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
useAppConsoleWebSocket, reusingmsgToBytesthat's designed to work for k8s channels, was incorrectly sending the "0x04" prefix which is equivalent to "Control+D" and logged out the user.Made-with: Cursor
Summary
libs/ui-components/.msgToBytesutility fromuseAppConsoleWebSocket.useWebSocket.0x04prefix that could triggerControl+Dand log out the user.Impact
libs/types/,libs/i18n/,libs/cypress/,apps/standalone/,apps/ocp-plugin/,proxy/,packaging/, or.github/workflows/.