EDM-4049: Do now show sync status of RS without repositories - #661
EDM-4049: Do now show sync status of RS without repositories#661celdrake wants to merge 1 commit into
Conversation
Made-with: Cursor
Summary by CodeRabbit
WalkthroughThe PR modifies ChangesRepository-aware ResourceSync Filtering
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@libs/ui-components/src/components/ResourceSync/ResourceSyncImportStatus.tsx`:
- Around line 167-180: The current memo treats repoList being undefined as “hide
all alerts”; change the logic so you only filter out RS entries when you
actually have a valid repoList—otherwise preserve the original lists. In the
React.useMemo for pendingRs/errorRs (referencing repoList, isLoadingRepos,
allPendingRs, allErrorRs, removeRsWithMissingRepositories), return { pendingRs:
allPendingRs, errorRs: allErrorRs } when repoList is undefined or loading, and
only call removeRsWithMissingRepositories when repoList is present
(non-undefined) to avoid suppressing alerts on transient fetch failures.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Enterprise
Run ID: 301ba0e6-2832-41a0-96a9-b624ef6b60a3
📒 Files selected for processing (1)
libs/ui-components/src/components/ResourceSync/ResourceSyncImportStatus.tsx
If users delete the repository that a RS is associated with, the UI was still showing the Pending/Error notification about that RS status.
Since eventually the RS will fail with a condition, and the resource sync status won't change while the repository is missing, we'll hide those notifications.