Manifest drives Android ABI list (per-minor android_abis)#21
Merged
Conversation
Each `pythons.<short>` entry in manifest.json now carries an `android_abis` array (64-bit first, `armeabi-v7a` trailing on 3.12 only — PEP 738 dropped 32-bit Android from 3.13). The Android build step in build-python-version.yml reads it via `jq` and loops `package-for-dart.sh` once per ABI, replacing the hardcoded `if version_int < 313 then armeabi-v7a` shell check. Adding or bumping a Python minor's ABI set is now a one-line manifest edit; the workflow + downstream consumers (serious_python's gen_version_tables, flet's manifest-driven registry) flow it through automatically. README schema note + the `android_abis` line added to the example. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
android_abisarray per Python minor inmanifest.json— 3.12 ships["arm64-v8a", "x86_64", "armeabi-v7a"], 3.13/3.14 are 64-bit-only (PEP 738). Ordering keeps the 64-bit list as a prefix of the 32-bit one.version_int < 313 then armeabi-v7ashell block in.github/workflows/build-python-version.ymlwith ajqread ofpythons.<short>.android_abis, looped intopackage-for-dart.sh. Fails loudly if the manifest has no entry.The intent is one-line-edit support for future minors: drop the
android_abisline in the manifest and the build/publish/Gradle/CLI consumers (serious_python'sgen_version_tables, flet's manifest-driven registry) flow it through automatically.Test plan
package-for-dart.sh install <full_version> <abi>invoked once per ABI listed in the manifest for each minor (3 for 3.12, 2 for 3.13/3.14).jq '.pythons."3.12".android_abis' manifest.jsonreturns["arm64-v8a", "x86_64", "armeabi-v7a"].workflow_dispatchand verify the publishedmanifest.jsonasset carriesandroid_abison every row.