Remove 32-bit x86 Android ABI references#20
Merged
Conversation
Flutter does not produce the 32-bit x86 ABI for Android, so building and packaging Python for it is dead weight. Drop x86 from the legacy 3.12 ABI list, the abi-to-host mapping, and the README. x86_64 and armeabi-v7a are retained.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flutter does not produce the 32-bit
x86ABI for Android, so building and packaging Python for it is dead weight. This drops every reference to the barex86ABI.x86_64(64-bit) andarmeabi-v7aare retained — both are still produced by Flutter.Changes
android/build-all.sh— removex86from the pre-3.13 ABI listandroid/abi-to-host.sh— remove thex86) → i686-linux-androidcaseandroid/README.md— dropx86from the Python 3.12 ABI listThe CI workflow and
manifest.jsonalready did not referencex86.Verification
grep -rnE "x86([^_]|$)" android/returns no barex86matches (onlyx86_64)abi-to-host.shstill resolvesx86_64→x86_64-linux-android;x86now hits the unknown-ABI fallback and exits non-zero