Allow clients to send signals with explicit destination - #78
Open
Molytho wants to merge 1 commit into
Open
Conversation
Currently clients are permitted to emit broadcast signals but are not allowed to emit signals with explicit destinations. This is an issue because of the following sequence: 1. An client calls a method on a sandboxed client => The sandboxed client starts some asynchronous operation and returns success 2. The sandboxed client wants to inform the client that something happend to the operation (e.g. it finished). The client does this by emitting a signal destined to the calling client. => The signal might be blocked if we don't have permission to send to the destination This behavior does not benefit security since a malicious client could just emit broadcast signals but breaks valid usecases thus this commit allows signals to be send to client that can be see. Closes: flatpak#25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently clients are permitted to emit broadcast signals but are not allowed to emit signals with explicit destinations.
This is an issue because of the following sequence:
This behavior does not benefit security since a malicious client could just emit broadcast signals but breaks valid usecases thus this commit allows signals to be send to client that can be see.
Closes: #25