Cache known GCP firmware indexed by MRTD#57
Draft
ameba23 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a cache for GCP firmware to avoid fetching the same data multiple times when verifying GCP DCAP attestations with the same MRTD value.
For context see: Easy-TEE/attest#13
Originally i wanted to add a 'pre-warm' as we do with PCS collateral, to initialize the cache with all known firmware, keeping potentially all network fetching out of the hot path. But i decided this would complicate things too much, decided to keep it as a simple cache which will fetch the first time an MRTD is encountered.