hex-encode certificate DN columns in the osquery detail queries - #94
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 34 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughCertificate queries for macOS and Windows now hex-encode distinguished-name fields. Shared ingestion logic decodes hexadecimal and legacy escaped values, logs invalid encodings, and clears undecodable fields. Both platforms use the shared decoder. Tests cover Unicode values, legacy values, platform-specific parsing, and malformed common names. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@server/service/osquery_utils/queries.go`:
- Around line 3506-3532: Complete the OPENFRAME sentinel metadata for all listed
fork edits: in server/service/osquery_utils/queries.go ranges 3506-3532,
3549-3551, and 3640-3642, add the change rationale to each existing sentinel
block; in server/service/osquery_utils/queries_test.go range 2947-3067, wrap the
OpenFrame-specific test with an OPENFRAME sentinel containing the change slug,
rationale, and documentation link.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 99d7c4b6-800f-45cb-a117-c7aa3c172648
⛔ Files ignored due to path filters (3)
openframe/docs/README.mdis excluded by!**/*.mdopenframe/docs/agent-inventory-waf-shape.mdis excluded by!**/*.mdopenframe/docs/fork-file-manifest.mdis excluded by!**/*.md
📒 Files selected for processing (2)
server/service/osquery_utils/queries.goserver/service/osquery_utils/queries_test.go
Summary by CodeRabbit
Bug Fixes
Tests