Skip to content

hex-encode certificate DN columns in the osquery detail queries - #94

Merged
ivan-flamingo merged 2 commits into
mainfrom
hotfix/permanent-l
Aug 7, 2026
Merged

hex-encode certificate DN columns in the osquery detail queries#94
ivan-flamingo merged 2 commits into
mainfrom
hotfix/permanent-l

Conversation

@ivan-flamingo

@ivan-flamingo ivan-flamingo commented Aug 7, 2026

Copy link
Copy Markdown

Summary by CodeRabbit

  • Bug Fixes

    • Improved certificate inventory processing on macOS and Windows by correctly decoding distinguished-name fields.
    • Preserved compatibility with existing plain-text certificate data.
    • Prevented malformed certificate names from being ingested as invalid raw values.
    • Improved handling of Unicode certificate names and escaped characters.
  • Tests

    • Added coverage for encoded, legacy, Unicode, platform-specific, and malformed certificate data.

@ivan-flamingo ivan-flamingo self-assigned this Aug 7, 2026
@ivan-flamingo
ivan-flamingo enabled auto-merge (squash) August 7, 2026 16:52
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 34 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a0fbc163-7a72-4a2e-8d57-dd89b70921d1

📥 Commits

Reviewing files that changed from the base of the PR and between 1206640 and 87ba159.

📒 Files selected for processing (2)
  • server/service/osquery_utils/queries.go
  • server/service/osquery_utils/queries_test.go

Walkthrough

Certificate queries for macOS and Windows now hex-encode distinguished-name fields. Shared ingestion logic decodes hexadecimal and legacy escaped values, logs invalid encodings, and clears undecodable fields. Both platforms use the shared decoder. Tests cover Unicode values, legacy values, platform-specific parsing, and malformed common names.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: hex-encoding certificate distinguished-name columns in osquery detail queries.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hotfix/permanent-l

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@server/service/osquery_utils/queries.go`:
- Around line 3506-3532: Complete the OPENFRAME sentinel metadata for all listed
fork edits: in server/service/osquery_utils/queries.go ranges 3506-3532,
3549-3551, and 3640-3642, add the change rationale to each existing sentinel
block; in server/service/osquery_utils/queries_test.go range 2947-3067, wrap the
OpenFrame-specific test with an OPENFRAME sentinel containing the change slug,
rationale, and documentation link.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 99d7c4b6-800f-45cb-a117-c7aa3c172648

📥 Commits

Reviewing files that changed from the base of the PR and between 3a8439b and 1206640.

⛔ Files ignored due to path filters (3)
  • openframe/docs/README.md is excluded by !**/*.md
  • openframe/docs/agent-inventory-waf-shape.md is excluded by !**/*.md
  • openframe/docs/fork-file-manifest.md is excluded by !**/*.md
📒 Files selected for processing (2)
  • server/service/osquery_utils/queries.go
  • server/service/osquery_utils/queries_test.go

Comment thread server/service/osquery_utils/queries.go Outdated
@ivan-flamingo
ivan-flamingo merged commit 0b322fe into main Aug 7, 2026
6 checks passed
@ivan-flamingo
ivan-flamingo deleted the hotfix/permanent-l branch August 7, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants