forked from fleetdm/fleet
-
Notifications
You must be signed in to change notification settings - Fork 1
ci: add Trivy security scan to PR pipeline #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
yaroslavmokflmg
wants to merge
8
commits into
main
Choose a base branch
from
security/trivy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+126
−0
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
38eeab5
ci: add Trivy security scan to PR pipeline
yaroslavmokflmg e47e7b4
ci: harden trivy gate — no persisted git credentials, visible warning…
yaroslavmokflmg 9c899aa
ci: make trivy gate non-blocking (allow fail) until devs have capacity
yaroslavmokflmg a333029
ci: trivy code+docker scan in one job, in-build image scan, per-scan …
yaroslavmokflmg 7ea71c1
ci: merge all trivy reports into one artifact per run, skip empty rep…
yaroslavmokflmg d3e6f47
ci: merge all trivy reports into one artifact per run, dedupe upload …
yaroslavmokflmg 07a1758
ci: compact trivy action — piped scans, unified evaluate, single merg…
yaroslavmokflmg 21c7f77
ci: report unique vulnerability count in trivy error message
yaroslavmokflmg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| name: "Trivy" | ||
| description: "Trivy PR security scans. scan: code = repo dependencies (HIGH/CRITICAL) + Dockerfile base images (CRITICAL), image = image built in the pipeline (HIGH/CRITICAL). Each scan uploads its TSV report as an artifact" | ||
|
|
||
| inputs: | ||
| scan: | ||
| description: "code | image" | ||
| required: true | ||
| maven-token: | ||
| description: "Token for internal GitHub Packages: Maven resolution (scan: code) and docker build secret (scan: image)" | ||
| required: false | ||
| default: ${{ github.token }} | ||
| image-name: | ||
| description: "Service name from the build matrix (scan: image)" | ||
| required: false | ||
| dockerfile: | ||
| description: "Path to the service Dockerfile (scan: image)" | ||
| required: false | ||
| context: | ||
| description: "Docker build context (scan: image)" | ||
| required: false | ||
|
|
||
| runs: | ||
| using: composite | ||
| steps: | ||
| - name: Install Trivy | ||
| uses: aquasecurity/setup-trivy@v0.3.1 | ||
| with: | ||
| version: v0.73.0 | ||
| cache: true | ||
|
|
||
| - name: Scan dependencies and Dockerfile base images | ||
| if: inputs.scan == 'code' | ||
| shell: bash | ||
| env: | ||
| GITHUB_TOKEN: ${{ inputs.maven-token }} | ||
| GITHUB_ACTOR: ${{ github.actor }} | ||
| run: | | ||
| set -euo pipefail | ||
| if [ -f pom.xml ]; then # warm ~/.m2 via Google's Central mirror so trivy sees parent-managed versions | ||
| echo '<settings><mirrors><mirror><id>google-central</id><url>https://maven-central.storage-download.googleapis.com/maven2/</url><mirrorOf>central</mirrorOf></mirror></mirrors></settings>' > /tmp/mirror.xml | ||
| mvn -B -q -fn -DskipTests -gs /tmp/mirror.xml $([ -f .mvn/settings.xml ] && echo '-s .mvn/settings.xml') dependency:go-offline | tee /tmp/mvn.log || true | ||
| ! grep -q '\[ERROR\]' /tmp/mvn.log || echo "::warning::Some Maven dependencies could not be resolved; scan depth may be reduced" | ||
| fi | ||
| trivy fs --no-progress --scanners vuln --severity HIGH,CRITICAL --ignore-unfixed --offline-scan --format json . | | ||
| jq -r '.Results[]? as $r | $r.Vulnerabilities[]? | [.Severity, .PkgName, .InstalledVersion, (.FixedVersion // "-"), .VulnerabilityID, $r.Target] | @tsv' | sort -u > "trivy-${GITHUB_REPOSITORY##*/}-code-report.tsv" | ||
|
|
||
| out="trivy-${GITHUB_REPOSITORY##*/}-docker-report.tsv"; : > "$out" | ||
| find . -name 'Dockerfile*' -not -path './.git/*' -not -path '*/node_modules/*' -print0 | | ||
| xargs -0 -r awk 'toupper($1)=="FROM" {i=$2; if (i ~ /^--/) i=$3; print i; if (toupper($3)=="AS") print "~"$4; if (toupper($4)=="AS") print "~"$5}' | sort -u > /tmp/from.txt | ||
| for img in $(grep -v '^~' /tmp/from.txt); do | ||
| [ "$img" = scratch ] && continue | ||
| case "$img" in *'$'*) echo "::warning::Skipping base image with unresolved variable: ${img}"; continue ;; esac | ||
| grep -qxF "~$img" /tmp/from.txt && continue | ||
| trivy image --no-progress --scanners vuln --severity CRITICAL --ignore-unfixed --format json "$img" | | ||
| jq -r --arg img "$img" '.Results[]? as $r | $r.Vulnerabilities[]? | [.Severity, .PkgName, .InstalledVersion, (.FixedVersion // "-"), .VulnerabilityID, $img] | @tsv' >> "$out" || | ||
| echo "::warning::Base image ${img} could not be scanned (pull/scan error); it was NOT checked" | ||
| done | ||
| sort -u "$out" -o "$out" | ||
| find . -maxdepth 1 -name 'trivy-*.tsv' -empty -delete | ||
|
|
||
| - name: Scan built image | ||
| if: inputs.scan == 'image' | ||
| shell: bash | ||
| env: | ||
| GITHUB_TOKEN: ${{ inputs.maven-token }} | ||
| GITHUB_ACTOR: ${{ github.actor }} | ||
| run: | | ||
| set -euo pipefail | ||
| docker buildx build --platform linux/amd64 --secret id=GITHUB_TOKEN,env=GITHUB_TOKEN --build-arg GITHUB_ACTOR="$GITHUB_ACTOR" \ | ||
| -f "${{ inputs.dockerfile }}" --output type=oci,dest=/tmp/image.tar "${{ inputs.context }}" | ||
| out="trivy-${GITHUB_REPOSITORY##*/}-image-report-${{ inputs.image-name }}.tsv" | ||
| trivy image --no-progress --scanners vuln --severity HIGH,CRITICAL --ignore-unfixed --input /tmp/image.tar --format json | | ||
| jq -r '.Results[]? as $r | $r.Vulnerabilities[]? | [.Severity, .PkgName, .InstalledVersion, (.FixedVersion // "-"), .VulnerabilityID, $r.Target] | @tsv' | sort -u > "$out" | ||
| find . -maxdepth 1 -name 'trivy-*.tsv' -empty -delete | ||
|
|
||
| - name: Upload report | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: ${{ inputs.scan == 'code' && format('trivy-{0}-code-report', github.event.repository.name) || format('trivy-{0}-image-report-{1}', github.event.repository.name, inputs.image-name) }} | ||
| path: trivy-*.tsv | ||
| if-no-files-found: ignore | ||
|
|
||
| - name: Evaluate | ||
| shell: bash | ||
| run: | | ||
| set -euo pipefail | ||
| files=$(ls trivy-*.tsv 2>/dev/null) || { echo "No vulnerabilities found."; exit 0; } | ||
| column -t -s "$(printf '\t')" $files | ||
| echo "::error::Trivy found $(cut -f1,2,5 $files | sort -u | wc -l | tr -d ' ') unique HIGH/CRITICAL vulnerabilities ($(cat $files | wc -l | tr -d ' ') occurrences across modules) in: ${files//$'\n'/, } (full report in the run artifacts)" | ||
| exit 1 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # Vulnerabilities to skip in the Trivy scan: one CVE/GHSA id per line, e.g.: | ||
| # | ||
| # CVE-2026-12345 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🔴 Critical | 🏗️ Heavy lift
🧩 Analysis chain
🏁 Script executed:
Repository: flamingo-stack/fleetmdm
Length of output: 309
🏁 Script executed:
Repository: flamingo-stack/fleetmdm
Length of output: 12620
🌐 Web query:
Maven Settings reference -s settings and -gs global settings can invoke code plugin extensions💡 Result:
Maven's settings.xml and global settings files cannot directly invoke or register code plugin extensions [1][2][3]. The Maven settings files (
~/.m2/settings.xmland${MAVEN_HOME}/conf/settings.xml) are designed for environment-specific configuration, such as local repository paths, authentication credentials, proxies, and profile definitions [2][4][3]. They do not possess the capability to load or activate Maven extensions [1][5]. Maven extensions, which adjust build behavior or add functionality to the Maven Core, are instead configured through the following dedicated mechanisms [5][6]: 1..mvn/extensions.xml: The standard, project-level approach for registering extensions [1][5]. You define the extension using its Maven coordinates (groupId, artifactId, version) within this file located in the project's root.mvn/directory [1][7]. 2. Project-level Build Extensions: Configured within a project'spom.xmlunder<build><extensions>or by setting<extensions>true</extensions>within a specific plugin configuration [5]. 3. Command Line: Extensions can be loaded temporarily using the-Dmaven.ext.class.path=extension.jarargument [1][5][6]. While settings files can define plugin groups (via the<pluginGroups>element) to simplify command-line execution by allowing Maven to resolve plugin group IDs automatically, this is distinct from invoking or loading code extensions [2][8].Citations:
🌐 Web query:
Maven dependency plugin lifecycle phases extensions settings include extensions in dependency tree documentation💡 Result:
The Apache Maven Dependency Plugin does not have a dedicated configuration setting or lifecycle phase parameter to explicitly "include extensions" in the dependency tree. In Maven, extensions (artifacts with the type
maven-extension) are typically loaded at the start of the build process to extend core Maven functionality and are generally not managed as standard project dependencies that appear in the typicalmvn dependency:treeoutput [1][2][3]. Key points regarding dependency tree and plugin configuration: 1. Dependency Tree Filtering: Thedependency:treegoal allows filtering by group ID, artifact ID, type, and version using theincludesandexcludesparameters [1][4][5]. Because extensions have a specificmaven-extensiontype, you can attempt to include them in the tree output by specifying this type in your filter pattern if they are present in the project's dependency graph [1][4]. The filter syntax follows the pattern[groupId]:[artifactId]:[type]:[version][1][4]. 2. Dependency Tree Scope: You can use thescopeparameter to filter the dependency tree resolution by a specific scope (e.g., compile, runtime, test), or leave it empty to include all scopes [1][2]. 3. Plugin Lifecycle: The Maven Dependency Plugin goals (liketree,list,copy-dependencies) can be bound to any lifecycle phase via the standard Maven plugin configuration in yourpom.xml[6]. However, they do not inherently alter how extensions are loaded or reported [1][7]. If you are trying to view or verify build extensions, these are usually defined in the<build><extensions>section of thepom.xmlor via project-level metadata, rather than as standard dependencies that thedependency:treegoal is designed to visualize [3].Citations:
🌐 Web query:
search.maven.org metadata maven extension type artifact extensions repository documentation💡 Result:
In Apache Maven, the term "extension" is used in two distinct, unrelated contexts that are often confused [1]. 1. Maven Build Extensions (Functional Extensions) These are JAR artifacts used to extend Maven's core functionality (e.g., adding wagon providers for repository transport or lifecycle enhancements) [2]. They are not defined by a "type" in the dependency sense, but are instead loaded via specific configurations in the project POM or command line [2]. - Configuration: Declared in the section of the pom.xml or via.mvn/extensions.xml [2][3]. - Documentation: Refer to the Maven guide on Using Extensions [2]. 2. Artifact Types and Extensions (File Extensions) In the context of repository metadata and dependency declarations, "extension" refers to the file format of an artifact (e.g., jar, pom, war) [1]. - Type: The element in a dependency declaration is used to determine the artifact's file extension, classifier, and how it is handled in the build (e.g., whether it is added to the classpath) [1][4][5]. - Mapping: Maven core defines default handlers that map specific "types" to their corresponding file extensions (e.g., the 'java-source' type maps to a 'jar' extension with a 'sources' classifier) [1][5]. Regarding search.maven.org: - Status: This service has been superseded by https://central.sonatype.com [6]. While the web interface has been redirected, the API remains available for programmatic access [6]. - Metadata: Repository metadata, including artifact file extensions, can be explored via the Central Repository REST API [7][8]. When searching, you can filter by artifact characteristics, though the distinction between a "build extension" and an "artifact extension" (file type) remains essential for interpreting results correctly [1][8].
Citations:
Remove package credentials from the pull-request scan.
trivy_scanchecks out PR code, grantspackages: read, and passes the GitHub token into Maven while also loading.mvn/settings.xmlfrom the PR. Treat thepackagesscope as untrusted for this workflow and do not expose the token to untrusted Maven configuration..github/steps/trivy/action.yml#L21-L23: do not exportmaven-tokenasGITHUB_TOKENfor pull-request scans..github/steps/trivy/action.yml#L37-L39: do not load.mvn/settings.xmlfrom the pull request when a credential is available; use a trusted settings file if credentials are required..github/workflows/test.yml#L40-L42: removepackages: readfrom the untrusted PR scan or keep credentials out of untrusted Maven execution.📍 Affects 2 files
.github/steps/trivy/action.yml#L21-L23(this comment).github/steps/trivy/action.yml#L37-L39.github/workflows/test.yml#L40-L48🤖 Prompt for AI Agents
Source: Linters/SAST tools