Skip to content

existingSecret instead of secretName - #91

Merged
ivan-flamingo merged 1 commit into
mainfrom
feature/bry
Jul 31, 2026
Merged

existingSecret instead of secretName#91
ivan-flamingo merged 1 commit into
mainfrom
feature/bry

Conversation

@ivan-flamingo

@ivan-flamingo ivan-flamingo commented Jul 31, 2026

Copy link
Copy Markdown

Summary by CodeRabbit

  • Bug Fixes

    • Improved MySQL TLS Secret handling across deployments, migrations, permissions, and vulnerability processing.
    • Configured externally managed database Secrets are now used when provided, with automatic fallback to the chart-managed Secret.
  • Documentation

    • Clarified when the database Secret name setting is used.

@ivan-flamingo ivan-flamingo self-assigned this Jul 31, 2026
@ivan-flamingo
ivan-flamingo merged commit beb5b4c into main Jul 31, 2026
1 of 2 checks passed
@ivan-flamingo
ivan-flamingo deleted the feature/bry branch July 31, 2026 12:56
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 65fed651-8dc0-4901-8aa9-f7f515a8fc01

📥 Commits

Reviewing files that changed from the base of the PR and between 7a91716 and 10616c5.

⛔ Files ignored due to path filters (1)
  • openframe/docs/helm-chart.md is excluded by !**/*.md
📒 Files selected for processing (5)
  • charts/fleet/templates/deployment.yaml
  • charts/fleet/templates/job-migration.yaml
  • charts/fleet/templates/rbac.yaml
  • charts/fleet/templates/vulnprocessing/cronjob.yaml
  • charts/fleet/values.yaml

Walkthrough

The Helm chart now uses database.existingSecret for MySQL TLS and RBAC Secret references when configured. It falls back to database.secretName when existingSecret is empty. The database Secret configuration comment documents this condition. The migration Job includes OpenFrame comments describing the Secret selection.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/bry

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant