[TLE] Add signal and signal_wait operators - #863
Draft
legilla wants to merge 57 commits into
Draft
Conversation
|
|
github-actions
Bot
added
DOC
legilla
requested review from
Galaxy1458,
i3wanna2,
menchunlei,
sunnycase and
zhzhcookie
as code owners
August 4, 2026 07:49
…_signal and tle_signal_wait primitives
Modified test_tle_signal_wait.py
legilla
marked this pull request as draft
August 16, 2026 07:46
FlagCX PR flagos-ai#539 (Unified IR) deletes flagcxDevNetSignalCtrIncS and makes remote counter increments unreachable; only local (send-side) counters remain, which TLE does not use. Remove the counter surface so kernels never emit the deleted symbol: - SignalOpKind: drop CTR (inc/add only) - SignalWaitKind: drop COUNTER (signal/shadow only) - Stop emitting flagcxDevNetSignalCtrIncS / flagcxDevNetWaitCounterS - Update Python frontend, verifiers, pybind enums, tests, and docs Remaining S-path calls (flagcxDevNetGetFromCommS, SignalSigIncS/SigAddS, WaitSignalS, WaitSignalMeetShadowS) are all retained by PR flagos-ai#539.
Rename VerfiyUtils.h/.cpp to VerifyUtils.h/.cpp (fix typo, update CMakeLists.txt and 3 include sites). Add shared signal-arg verification functions in the Signal namespace: - verifySignalOp(SignalOpKind, mlir::Value) -> optional<string> - verifySignalWaitOp(SignalWaitKind, mlir::Value) -> optional<string> Return nullopt when valid, otherwise a user-facing error message (Python-style: 'value must be provided when op is add' etc.). Use in MLIR verifiers (4 one-liners in Ops.cpp / FlagCxOps.cpp), as a pre-creation check in the pybind create_signal / create_signal_wait lambdas (throws py::value_error), and via a new tle.utils submodule (verify_signal / verify_signal_wait) consumed by distributed.py signal() / signal_wait().
# Conflicts: # .github/workflows/nvidia3.6-build-and-test.yml # third_party/tle/dialect/lib/Conversion/TleToLLVM/FlagCxOpToLLVM/CMakeLists.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.