feat(dag): add the security platform to the framework graph#8
Merged
Conversation
Register the 14 new fireflyframework-security-* platform modules (api, spi, core, webflux, resource-server, method-policy, oauth2-client, authorization-server, test, and the opa/cerbos/openfga/ vault/r2dbc adapters) in the dependency DAG and the clone list, with edges derived from each module's pom.xml. Also rename the five idp repos to their new security-idp[-*] coordinates. Without this, fwversion/release/setup skipped the entire security family and still referenced the old fireflyframework-idp* repo names. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes the
flyworkCLI aware of the fireflyframework-security-* family sofwversion,release,dag, andsetupinclude it.internal/dag/graph.go— adds the 14 platform modules as DAG nodes with edges derived from eachpom.xml:api ← spi ← core ← webfluxresource-server ← webflux;method-policy ← core,webflux;authorization-server ← core,spi;oauth2-client(Spring-only, no internal deps);test ← api,spi,webfluxopa/cerbos/openfga/vault/r2dbc) ←api,spistarter-application←resource-server,method-policysecurity-idp[-*]internal/setup/cloner.go— renames the idp repos and adds the 14 platform repos toFrameworkRepos.Why
The graph/clone list predated the security family.
fwversion/releaseiterate this list, so the entire security platform was skipped and the oldfireflyframework-idp*repo names (now renamed) were still referenced — blocking the 26.06.x release of security.Verification
go build ./...,go vet,gofmtcleanflywork dag layers/dag exportsucceed (acyclic) and place every security module in a topologically correct layerflywork fwversion shownow lists the 19 security repos🤖 Generated with Claude Code