Skip to content

feat(firebase_app_check,windows): add custom App Check provider support - #18576

Open
SelaseKay wants to merge 3 commits into
mainfrom
feat/windows-custom-app-check-provider
Open

feat(firebase_app_check,windows): add custom App Check provider support#18576
SelaseKay wants to merge 3 commits into
mainfrom
feat/windows-custom-app-check-provider

Conversation

@SelaseKay

@SelaseKay SelaseKay commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Description

Adds custom App Check provider support for Windows, addressing the custom-provider part of #12227. Combined with the existing Windows debug provider, this lets Flutter Windows apps meet App Check enforcement for Firestore, Functions, Storage, Auth, and Realtime Database.

Previously, Windows activate() always installed the C++ debug provider. Apps can now pass WindowsCustomProvider(fetchToken: ...) so the native plugin asks Dart for a minted token (and its expiry) whenever the Firebase C++ SDK needs a fresh App Check token.

Usage:

await FirebaseAppCheck.instance.activate(
  providerWindows: WindowsCustomProvider(
    fetchToken: () async {
      final response = await myBackend.mintAppCheckToken();
      return CustomAppCheckToken(
        token: response.token,
        expireTimeMillis: response.expireTimeMillis,
      );
    },
  ),
);

fetchToken is invoked by the plugin when the native SDK needs a token. App code never touches generated Pigeon FirebaseAppCheckFlutterApi; a private method-channel implementation registers that callback per app.name. The native factory is process-global and long-lived, with per-app custom vs debug dispatch at GetToken time.

This reimplements closed #18184 on current main (including recaptchaSiteKey on activate) and incorporates the review feedback from that PR.

Related Issues

#12227

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Allow Flutter Windows apps to mint App Check tokens through a Dart
WindowsCustomProvider callback, with app-scoped native wiring.
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 馃憤 and 馃憥 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@SelaseKay
SelaseKay force-pushed the feat/windows-custom-app-check-provider branch from 80b703d to 2d81d43 Compare August 18, 2026 15:53
@SelaseKay
SelaseKay marked this pull request as ready for review August 19, 2026 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants