Skip to content

feat(analytics,ios): add UIScene support for campaign attribution - #18573

Open
SelaseKay wants to merge 2 commits into
mainfrom
feat/analytics-ios-uiscene
Open

feat(analytics,ios): add UIScene support for campaign attribution#18573
SelaseKay wants to merge 2 commits into
mainfrom
feat/analytics-ios-uiscene

Conversation

@SelaseKay

@SelaseKay SelaseKay commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Description

Under the UIScene lifecycle, UIKit delivers URL and universal-link opens to UISceneDelegate instead of UIApplicationDelegate. Firebase Analytics only swizzles AppDelegate, so firebase_campaign was silently dropped after a host app adopted UIScene. Other Analytics events kept working; the loss is only visible in BigQuery.

This registers the iOS plugin as a scene delegate (when the Flutter SDK provides addSceneDelegate) and forwards:

  • scene:willConnectToSession:options: (cold start) to Analytics.handleOpen and Analytics.handleUserActivity
  • scene:openURLContexts: to Analytics.handleOpen
  • scene:continueUserActivity: to Analytics.handleUserActivity

The scene methods return false so Auth, Messaging, and other plugins still receive the same events. The plugin does not conform to FlutterSceneLifeCycleDelegate at compile time so it still builds against Flutter 3.27; the methods use matching @objc selectors instead.

Automated Dart tests cannot observe firebase_campaign (native UIKit callbacks, BigQuery-only event). Verification remains the issue repro: UIScene host app, simctl openurl with UTM params, BigQuery export.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Forward scene URL and user-activity callbacks to Analytics.handleOpen / handleUserActivity so firebase_campaign is recorded when the host app uses UIScene.
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 馃憤 and 馃憥 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[firebase_analytics]: campaign attribution (firebase_campaign) silently stops working on iOS under the UIScene lifecycle

1 participant