Add npm shrinkwrap to all kits - #2966
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates package names to the @firebase-function-kits scope and adds vitest as a development dependency across several Firebase function kits. It also introduces a new shrinkwrap file for firestore-incremental-capture. The reviewer suggests changing the version of firestore-bigquery-export to 0.0.0 for consistency with the other updated kits.
| "name": "@firebase/firestore-bigquery-export", | ||
| "version": "0.1.0", | ||
| "name": "@firebase-function-kits/firestore-bigquery-export", | ||
| "version": "0.0.1", |
There was a problem hiding this comment.
This package's version is set to 0.0.1, while other packages in this PR are updated to 0.0.0. To maintain consistency across the kits, this should also be 0.0.0 unless there is a specific reason for it to be different.
| "version": "0.0.1", | |
| "version": "0.0.0", |
There was a problem hiding this comment.
Sign that AI didn't regenerate. I don't generally review package lock files since they're massive and robo created. Forced recreation of all files, so this should hopefully be fixed.
c826a3c to
ec44cd6
Compare
ec44cd6 to
4f8044e
Compare
3 participants
Converts package-lock.json files to npm-shrinkwrap.json and adds npm-shrinkwrap.json for all subdirectories under kits/.